[PR #34] [MERGED] Replace ad-hoc pagination by FmPagination from finmars-ui #34

New issue

Closed

opened 2026-03-03 12:00:24 +03:00 by kerem · 0 comments

kerem commented 2026-03-03 12:00:24 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/finmars-platform/finmars-workflow-portal/pull/34
Author: @HenkKalkwater
Created: 2/9/2026
Status: ✅ Merged
Merged: 2/10/2026
Merged by: @HenkKalkwater

Base: main ← Head: 168-workflow-pagination

---

📝 Commits (2)

• 88becb8 Replace ad-hoc pagination by FmPagination from finmars-ui
• c482687 workflow(-template): Move data fetch from onMounted to useAsyncData

📊 Changes

2 files changed (+74 additions, -171 deletions)

View changed files

📝 src/pages/workflow-template/index.vue (+32 -70)
📝 src/pages/workflow/index.vue (+42 -101)

📄 Description

This fixes the overflowing navigation problem and makes the pagination consistent with the rest of the application.

Known issue: when reloading the page, the pagination component always thinks it's on page 0. Fixed in c48268766a

Fixes finmars-platform/finmars-core#98 and finmars-platform/finmars-core#168

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/finmars-platform/finmars-workflow-portal/pull/34 **Author:** [@HenkKalkwater](https://github.com/HenkKalkwater) **Created:** 2/9/2026 **Status:** ✅ Merged **Merged:** 2/10/2026 **Merged by:** [@HenkKalkwater](https://github.com/HenkKalkwater) **Base:** `main` ← **Head:** `168-workflow-pagination` --- ### 📝 Commits (2) - [`88becb8`](https://github.com/finmars-platform/finmars-workflow-portal/commit/88becb8910417c20bbcfd469e19797ff97c6a067) Replace ad-hoc pagination by FmPagination from finmars-ui - [`c482687`](https://github.com/finmars-platform/finmars-workflow-portal/commit/c48268766a5e725e3e861d8b48f825c846e568ef) workflow(-template): Move data fetch from onMounted to useAsyncData ### 📊 Changes **2 files changed** (+74 additions, -171 deletions) <details> <summary>View changed files</summary> 📝 `src/pages/workflow-template/index.vue` (+32 -70) 📝 `src/pages/workflow/index.vue` (+42 -101) </details> ### 📄 Description This fixes the overflowing navigation problem and makes the pagination consistent with the rest of the application. ~Known issue: when reloading the page, the pagination component always thinks it's on page 0.~ Fixed in c48268766a5e725e3e861d8b48f825c846e568ef Fixes finmars-platform/finmars-core#98 and finmars-platform/finmars-core#168 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-03-03 12:00:24 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

182-update-sidenav

PLAT-1836

PLAT-1787

1.16.0-rc

1.16.0-stable

1.17.0-rc

1.17.0-stable

1.17.1-stable

PLAT-1701

1.15.0-rc

1.15.0-stable

1.15.1-stable

1.15.2-stable

1.14.0-rc

1.14.0-stable

1.11.0-rc

1.11.0-stable

1.11.1-stable

1.11.3-stable

1.11.4-stable

1.12.0-rc

1.12.0-stable

1.13.0-rc

1.13.0-stable

1.13.1-stable

master

1.24.2-rc

1.24.1-rc

1.23.1-stable

1.24.0-stable

1.23.1-rc

1.22.2-rc

1.22.2-stable

1.23.0-stable

1.22.1-rc

1.22.1-stable

1.21.10-rc

1.22.0-stable

1.21.10-stable

1.21.9-rc

1.21.9-stable

1.21.8-rc

1.21.8-stable

1.21.7-rc

1.21.7-stable

1.21.6-rc

1.21.6-stable

1.21.5-rc

1.21.5-stable

1.21.4-rc

1.21.4-stable

1.21.3-rc

1.21.2-rc

1.21.2-stable

1.21.1-stable

1.21.1-rc

1.21.0-stable

1.20.10-rc

1.20.9-rc

1.20.8-rc

1.20.7-rc

1.20.6-rc

1.20.5-rc

1.20.4-rc

1.20.3-rc

1.20.2-rc

1.20.2-stable

1.20.1-stable

1.20.1-rc

1.19.4-rc

1.20.0-stable

1.19.3-rc

1.19.2-rc

1.19.1-rc

1.18.2-rc

1.19.0-stable

1.18.1-rc

1.17.4-rc

1.18.0-stable

1.17.3-rc

1.17.2-rc

1.17.1-rc

1.17.0

Labels

Clear labels   

pull-request

Mirrored from GitHub Pull Request

No labels

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/finmars-workflow-portal#34

No description provided.