[PR #504] [MERGED] Add CRC32 and MD5 hashes for preseeded files #667

New issue

Closed

opened 2026-03-03 12:31:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:31:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/504
Author: @IlyaM
Created: 5/27/2021
Status: ✅ Merged
Merged: 6/3/2021
Merged by: @fsouza

Base: main ← Head: checksums-on-seed

📝 Commits (1)

2759ac7 Add CRC32 and MD5 hashes for preseeded files

📊 Changes

3 files changed (+13 additions, -11 deletions)

View changed files

📝 fakestorage/upload.go (+10 -10)
📝 fakestorage/upload_test.go (+1 -1)
📝 main.go (+2 -0)

📄 Description

This patch adds CRC32 and MD5 hashes for files preloaded from the seed directory. I believe this closes the issue https://github.com/fsouza/fake-gcs-server/issues/313

I haven't noticed any preexisting tests for this functionality so I only tested the patch manually. Probably it makes sense to move CRC32 and MD5 functions out of upload.go into a separate file as they are now used in multiple places but I didn't do this to keep the patch small.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/504 **Author:** [@IlyaM](https://github.com/IlyaM) **Created:** 5/27/2021 **Status:** ✅ Merged **Merged:** 6/3/2021 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `checksums-on-seed` --- ### 📝 Commits (1) - [`2759ac7`](https://github.com/fsouza/fake-gcs-server/commit/2759ac7b90e463ffd51538b39324358152717646) Add CRC32 and MD5 hashes for preseeded files ### 📊 Changes **3 files changed** (+13 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/upload.go` (+10 -10) 📝 `fakestorage/upload_test.go` (+1 -1) 📝 `main.go` (+2 -0) </details> ### 📄 Description This patch adds CRC32 and MD5 hashes for files preloaded from the seed directory. I believe this closes the issue https://github.com/fsouza/fake-gcs-server/issues/313 I haven't noticed any preexisting tests for this functionality so I only tested the patch manually. Probably it makes sense to move CRC32 and MD5 functions out of upload.go into a separate file as they are now used in multiple places but I didn't do this to keep the patch small. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>