[PR #307] [MERGED] add support for MD5 checksum of object content when using fs #504

Closed
opened 2026-03-03 12:30:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/307
Author: @antonydenyer
Created: 8/12/2020
Status: Merged
Merged: 8/26/2020
Merged by: @fsouza

Base: mainHead: main


📝 Commits (1)

  • 7d6df31 add support for MD5 checksum of object content when using fs

📊 Changes

2 files changed (+42 additions, -3 deletions)

View changed files

📝 internal/backend/backend_test.go (+6 -3)
📝 internal/backend/fs.go (+36 -0)

📄 Description

Copy pasted md5 and crc hash functions from upload.go.

I compared the results against actually uploading to GCS (and using gsutil hash -m) and they differ for some reason. Whilst this is somewhat annoying it isn't a problem for me as all I need is something consistent.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/307 **Author:** [@antonydenyer](https://github.com/antonydenyer) **Created:** 8/12/2020 **Status:** ✅ Merged **Merged:** 8/26/2020 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`7d6df31`](https://github.com/fsouza/fake-gcs-server/commit/7d6df31d8d6d4db9cdaef9c5e87b0fc3eea237c6) add support for MD5 checksum of object content when using fs ### 📊 Changes **2 files changed** (+42 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `internal/backend/backend_test.go` (+6 -3) 📝 `internal/backend/fs.go` (+36 -0) </details> ### 📄 Description Copy pasted md5 and crc hash functions from `upload.go`. I compared the results against actually uploading to GCS (and using `gsutil hash -m`) and they differ for some reason. Whilst this is somewhat annoying it isn't a problem for me as all I need is something consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:30:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#504
No description provided.