[PR #452] [MERGED] Add application/json content type where required #625

New issue

Closed

opened 2026-03-03 12:30:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:30:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/452
Author: @cgreening
Created: 3/15/2021
Status: ✅ Merged
Merged: 3/15/2021
Merged by: @fsouza

Base: main ← Head: content-type-fix

📝 Commits (3)

fc24a12 Add application/json content type where required
f090629 Move content-type closer to encode
5873dea Move content header closer to encode

📊 Changes

3 files changed (+23 additions, -1 deletions)

View changed files

📝 fakestorage/bucket.go (+3 -0)
📝 fakestorage/object.go (+9 -0)
📝 fakestorage/upload.go (+11 -1)

📄 Description

This seems to be a bit horrible as I've had to add the header everywhere JSON is returned. I don't know if there's a better way to do this.

Fixes: https://github.com/fsouza/fake-gcs-server/issues/451

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/452 **Author:** [@cgreening](https://github.com/cgreening) **Created:** 3/15/2021 **Status:** ✅ Merged **Merged:** 3/15/2021 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `content-type-fix` --- ### 📝 Commits (3) - [`fc24a12`](https://github.com/fsouza/fake-gcs-server/commit/fc24a126d65806b98f529de855aa3e0109fa8883) Add application/json content type where required - [`f090629`](https://github.com/fsouza/fake-gcs-server/commit/f090629dbcf328f4a54a9588905d926f92b2c2f2) Move content-type closer to encode - [`5873dea`](https://github.com/fsouza/fake-gcs-server/commit/5873dea7b06c06b65625e43e318e16b1d1d7b1ac) Move content header closer to encode ### 📊 Changes **3 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/bucket.go` (+3 -0) 📝 `fakestorage/object.go` (+9 -0) 📝 `fakestorage/upload.go` (+11 -1) </details> ### 📄 Description This seems to be a bit horrible as I've had to add the header everywhere JSON is returned. I don't know if there's a better way to do this. Fixes: https://github.com/fsouza/fake-gcs-server/issues/451 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>