[PR #243] [MERGED] Add EXPOSE to Dockerfile #452

New issue

Closed

opened 2026-03-03 12:30:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:30:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/243
Author: @simondrake
Created: 5/12/2020
Status: ✅ Merged
Merged: 5/12/2020
Merged by: @fsouza

Base: master ← Head: master

📝 Commits (2)

726c876 Add EXPOSE to Dockerfile
307fb8f Remove IDE setting from gitignore

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 Dockerfile (+1 -0)

📄 Description

What is being changed

Add an EXPOSE command to the projects Dockerfile

Why are we making this change?

In order to use the Docker image in CI pipelines, it's imperative that the EXPOSE command is in the Dockerfile.

For example, see How the health check of services works from the Gitlab CI runner documentation. Specifically, the part which states:

Checks which ports are exposed from the container by default

Without this, the pipeline will fail with an invalid host/port error.

This change has also been published to Docker Hub to prove that it now works as expected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/243 **Author:** [@simondrake](https://github.com/simondrake) **Created:** 5/12/2020 **Status:** ✅ Merged **Merged:** 5/12/2020 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`726c876`](https://github.com/fsouza/fake-gcs-server/commit/726c8768f881d8c6c6122c34e6dfa402c800f306) Add EXPOSE to Dockerfile - [`307fb8f`](https://github.com/fsouza/fake-gcs-server/commit/307fb8f1906f944cd83972041bfe46f5ce99510d) Remove IDE setting from gitignore ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+1 -0) </details> ### 📄 Description ## What is being changed Add an `EXPOSE` command to the projects `Dockerfile` ## Why are we making this change? In order to use the Docker image in CI pipelines, it's imperative that the `EXPOSE` command is in the `Dockerfile`. For example, see [How the health check of services works](https://docs.gitlab.com/ee/ci/docker/using_docker_images.html#how-the-health-check-of-services-works) from the Gitlab CI runner documentation. Specifically, the part which states: > Checks which ports are exposed from the container by default Without this, the pipeline will fail with an invalid host/port error. This change has also been published to [Docker Hub](https://hub.docker.com/repository/docker/omisnomis/fake-gcs-server) to prove that it now works as expected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>