[PR #421] [MERGED] object: fix acl and project team json marshalling #596

New issue

Closed

opened 2026-03-03 12:30:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:30:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/421
Author: @visualage
Created: 2/14/2021
Status: ✅ Merged
Merged: 2/23/2021
Merged by: @fsouza

Base: main ← Head: main

📝 Commits (2)

1b2d394 object: fix acl and project team json marshalling
5b8a39c Address comments by not exporting internal marshalling types

📊 Changes

1 file changed (+163 additions, -13 deletions)

View changed files

📝 fakestorage/object.go (+163 -13)

📄 Description

This partially address #420. The current ACL list does not comply with the response marshalling because the JSON field names are different than the storage.ACLRule field names. Created a type alias ACLRule from storage.ACLRule, and added custom Marshalling. Did same for storage.ProjectTeam.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/421 **Author:** [@visualage](https://github.com/visualage) **Created:** 2/14/2021 **Status:** ✅ Merged **Merged:** 2/23/2021 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`1b2d394`](https://github.com/fsouza/fake-gcs-server/commit/1b2d394038e412f3729fbd1366478af405c784ab) object: fix acl and project team json marshalling - [`5b8a39c`](https://github.com/fsouza/fake-gcs-server/commit/5b8a39ca8cec1aaa13726885a9df53368a8b5ebc) Address comments by not exporting internal marshalling types ### 📊 Changes **1 file changed** (+163 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+163 -13) </details> ### 📄 Description This partially address #420. The current ACL list does not comply with the response marshalling because the JSON field names are different than the `storage.ACLRule` field names. Created a type alias `ACLRule` from `storage.ACLRule`, and added custom Marshalling. Did same for `storage.ProjectTeam`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>