[PR #189] [MERGED] Implement minimal support for PATCH metadata API #420

Closed
opened 2026-03-03 12:29:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/189
Author: @snawaz
Created: 3/3/2020
Status: Merged
Merged: 3/6/2020
Merged by: @fsouza

Base: masterHead: impl-minimal-patch


📝 Commits (2)

  • 60ab22a Implement minimal support for PATCH metadata API
  • 1ef837b Add test for PATCH API

📊 Changes

6 files changed (+117 additions, -0 deletions)

View changed files

📝 fakestorage/object.go (+22 -0)
📝 fakestorage/object_test.go (+63 -0)
📝 fakestorage/server.go (+1 -0)
📝 internal/backend/fs.go (+15 -0)
📝 internal/backend/memory.go (+15 -0)
📝 internal/backend/storage.go (+1 -0)

📄 Description

This PR implements minimal support for PATCH object's metadata API.

It patches the object's metadata as per path parameters and metadata in the request body. It completely ignores the optional query parameters of the API, which are slightly complex. So if this minimal support is acceptable, then we can merge it, and the optional query parameters can be taken care of in later PRs (if needed).

API Ref: https://cloud.google.com/storage/docs/json_api/v1/objects/patch


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/189 **Author:** [@snawaz](https://github.com/snawaz) **Created:** 3/3/2020 **Status:** ✅ Merged **Merged:** 3/6/2020 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `impl-minimal-patch` --- ### 📝 Commits (2) - [`60ab22a`](https://github.com/fsouza/fake-gcs-server/commit/60ab22a7b64418b60cae847bce292d9f606243a4) Implement minimal support for PATCH metadata API - [`1ef837b`](https://github.com/fsouza/fake-gcs-server/commit/1ef837bc0bf2d40274c5c591a8a577c84eea7674) Add test for PATCH API ### 📊 Changes **6 files changed** (+117 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/object.go` (+22 -0) 📝 `fakestorage/object_test.go` (+63 -0) 📝 `fakestorage/server.go` (+1 -0) 📝 `internal/backend/fs.go` (+15 -0) 📝 `internal/backend/memory.go` (+15 -0) 📝 `internal/backend/storage.go` (+1 -0) </details> ### 📄 Description This PR implements minimal support for `PATCH` object's metadata API. It patches the object's metadata as per `path parameters` and `metadata` in the request body. It _completely_ ignores the `optional query parameters` of the API, which are slightly complex. So if this minimal support is acceptable, then we can merge it, and the optional query parameters can be taken care of in later PRs (if needed). API Ref: https://cloud.google.com/storage/docs/json_api/v1/objects/patch --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 12:29:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/fake-gcs-server#420
No description provided.