[PR #300] [MERGED] Add basic implementation of ifGenerationMatch precondition. #500

New issue

Closed

opened 2026-03-03 12:30:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:30:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/300
Author: @charleskorn
Created: 8/5/2020
Status: ✅ Merged
Merged: 8/26/2020
Merged by: @fsouza

Base: main ← Head: main

📝 Commits (4)

3f67582 Add basic implementation of ifGenerationMatch precondition.
c3eee98 Refactor tests.
81679de Simplify test even further.
8a7cd30 Fix misuse of Fatalf().

📊 Changes

2 files changed (+83 additions, -0 deletions)

View changed files

📝 fakestorage/upload.go (+24 -0)
📝 fakestorage/upload_test.go (+59 -0)

📄 Description

It only supports checking if the file does not exist, and does not support checking for a particular generation. In these unsupported cases, it will return a HTTP not implemented error to the client.

See #299.

Documentation: https://cloud.google.com/storage/docs/json_api/v1/objects/update#parameters

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/300 **Author:** [@charleskorn](https://github.com/charleskorn) **Created:** 8/5/2020 **Status:** ✅ Merged **Merged:** 8/26/2020 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`3f67582`](https://github.com/fsouza/fake-gcs-server/commit/3f67582a13a6dd01ee4fdc7cf4927962e49748cf) Add basic implementation of ifGenerationMatch precondition. - [`c3eee98`](https://github.com/fsouza/fake-gcs-server/commit/c3eee9876e8099939608dc84e440e22d7f40c75b) Refactor tests. - [`81679de`](https://github.com/fsouza/fake-gcs-server/commit/81679dec737feb94624c4164ce9eaf0ce511b3de) Simplify test even further. - [`8a7cd30`](https://github.com/fsouza/fake-gcs-server/commit/8a7cd30fcd0f06b0314789b819101f3357c7c48b) Fix misuse of Fatalf(). ### 📊 Changes **2 files changed** (+83 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/upload.go` (+24 -0) 📝 `fakestorage/upload_test.go` (+59 -0) </details> ### 📄 Description It only supports checking if the file does not exist, and does not support checking for a particular generation. In these unsupported cases, it will return a HTTP not implemented error to the client. See #299. Documentation: https://cloud.google.com/storage/docs/json_api/v1/objects/update#parameters --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>