[PR #54] [MERGED] Python example - set the public host #299

New issue

Closed

opened 2026-03-03 12:10:09 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:10:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/54
Author: @jwhitlock
Created: 8/6/2019
Status: ✅ Merged
Merged: 8/7/2019
Merged by: @fsouza

Base: master ← Head: python-public-host

📝 Commits (1)

97d29ee Python example - set the public host

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 examples/python/python.py (+7 -5)

📄 Description

Change BASE_URL to EXTERNAL_URL, to mirror the setting in the fakestorage server. Add PUBLIC_HOST as well, to allow coordinating the public download host with the fakestorage server.

This may be the problem behind issues #53. I've tested similar but more complicated code in https://github.com/jwhitlock/test-fake-gcs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/54 **Author:** [@jwhitlock](https://github.com/jwhitlock) **Created:** 8/6/2019 **Status:** ✅ Merged **Merged:** 8/7/2019 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `python-public-host` --- ### 📝 Commits (1) - [`97d29ee`](https://github.com/fsouza/fake-gcs-server/commit/97d29ee6ff7fff4e8859ce40d729bbf30cd6e6cf) Python example - set the public host ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `examples/python/python.py` (+7 -5) </details> ### 📄 Description Change ``BASE_URL`` to ``EXTERNAL_URL``, to mirror the setting in the ``fakestorage`` server. Add ``PUBLIC_HOST`` as well, to allow coordinating the public download host with the ``fakestorage`` server. This may be the problem behind issues #53. I've tested similar but more complicated code in https://github.com/jwhitlock/test-fake-gcs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>