[PR #108] [MERGED] multipartUpload accepts object name in query param #345

New issue

Closed

opened 2026-03-03 12:29:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 12:29:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fsouza/fake-gcs-server/pull/108
Author: @chrisrecalis
Created: 10/24/2019
Status: ✅ Merged
Merged: 10/24/2019
Merged by: @fsouza

Base: master ← Head: multipart-upload-query-params

📝 Commits (2)

210f44e multipartUpload accepts object name in query param
d3fb3ef Update fakestorage/upload.go

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 fakestorage/upload.go (+7 -1)

📄 Description

As per documentation: https://cloud.google.com/storage/docs/json_api/v1/objects/insert the name of the object can either come from the query parameters or from the body.

It seems like its up to the implementors on which one to choose as the go storage client will send the name inside the body whereas the nodejs client sends it in the query params

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fsouza/fake-gcs-server/pull/108 **Author:** [@chrisrecalis](https://github.com/chrisrecalis) **Created:** 10/24/2019 **Status:** ✅ Merged **Merged:** 10/24/2019 **Merged by:** [@fsouza](https://github.com/fsouza) **Base:** `master` ← **Head:** `multipart-upload-query-params` --- ### 📝 Commits (2) - [`210f44e`](https://github.com/fsouza/fake-gcs-server/commit/210f44ebef5ff24e052fff6e60af2feb0efb1578) multipartUpload accepts object name in query param - [`d3fb3ef`](https://github.com/fsouza/fake-gcs-server/commit/d3fb3efcdcc4bf4046730a4ae36d7b6e9c43ffe9) Update fakestorage/upload.go ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `fakestorage/upload.go` (+7 -1) </details> ### 📄 Description As per documentation: https://cloud.google.com/storage/docs/json_api/v1/objects/insert the name of the object can either come from the query parameters or from the body. It seems like its up to the implementors on which one to choose as the `go` storage client will send the name inside the body whereas the `nodejs` client sends it in the query params --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>