mirror of
https://github.com/fsouza/fake-gcs-server.git
synced 2026-04-25 21:55:56 +03:00
[GH-ISSUE #590] Allow specification of Location #108
Labels
No labels
bug
compatibility-issue
docker
documentation
enhancement
help wanted
needs information
pull-request
question
stale
unfortunate
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/fake-gcs-server#108
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mdedetrich on GitHub (Oct 4, 2021).
Original GitHub issue: https://github.com/fsouza/fake-gcs-server/issues/590
I am attempting to use face-gcs-server along with Alpakka, specifically https://github.com/akka/alpakka/tree/master/google-cloud-storage/src and I am currently experiencing the issue where when you try to get the details of a bucket (i.e.
GET http://0.0.0.0//storage/v1/b/<some-bucket>) the response is missing thelocationfield in the JSON.I understand that fake-gcs-server doesn't return a
locationfield because fake-gcs-server doesn't really have a concept oflocationbut since its a mandatory field this is causing alpakka gcs client to not work, the JSON deserialization is failing withMaybe it makes sense to add a
-locationparameter the options which can hardcode a location (such as"EUROPE-WEST3")? Alternately when you create a bucket that specifies alocationthis can be persisted so that its returned whenever you doGET http://0.0.0.0//storage/v1/b/<some-bucket>.@fsouza commented on GitHub (Oct 4, 2021):
Yeah if that's a parameter on bucket creation we should persist it and return where applicable.
Do you know if any other fields are missing?
@mdedetrich commented on GitHub (Oct 4, 2021):
Unfortunately the JSON parser that is used short circuits as soon as it finds the first missing field so I only know that the
locationfield is missing but for reference these are the fields that its looking for (all of which are mandatory)If this is not helpful enough I can print out the response to see if there are any other missing fields?
@fsouza commented on GitHub (Oct 4, 2021):
Oh ok from that type definition I assume the only thing missing is location. I can work on it some time this week, but let me know if you'd prefer to send a PR.
I think we probably want to:
@mdedetrich commented on GitHub (Oct 4, 2021):
I am not that familiar with Go and its not that urgent for me so I am happy waiting if you are fine with working on it (otherwise let me know and I will try and work on it later on).
Yup sounds great from my end, having a command line arg such as
default-regionseems appropriate for the last point