[PR #377] [CLOSED] refactor: Refactor code #924

New issue

Closed

opened 2026-02-26 19:31:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:31:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/377
Author: @Dhoni77
Created: 9/15/2023
Status: ❌ Closed

Base: main ← Head: refactor/code

📝 Commits (4)

9ed3364 Use template literals to concatenate strings to make code more readable
52aa9cd Refactor apis
f2b0884 Improve logic to delete recipient
2490848 Added utility to serialize data

📊 Changes

16 files changed (+58 additions, -90 deletions)

View changed files

📝 apps/web/components/editor/pdf-editor.tsx (+3 -5)
📝 apps/web/components/navigation.tsx (+1 -1)
📝 apps/web/pages/api/documents/[id].ts (+1 -2)
📝 apps/web/pages/api/documents/[id]/fields/[fid].ts (+0 -6)
📝 apps/web/pages/api/documents/[id]/recipients/[rid].ts (+1 -6)
📝 apps/web/pages/documents.tsx (+16 -16)
📝 apps/web/pages/documents/[id]/index.tsx (+5 -5)
📝 apps/web/pages/documents/[id]/recipients.tsx (+11 -19)
📝 apps/web/pages/documents/[id]/sign.tsx (+4 -3)
📝 apps/web/pages/documents/[id]/signed.tsx (+5 -7)
📝 packages/lib/api/createOrUpdateField.ts (+1 -1)
📝 packages/lib/api/createOrUpdateRecipient.ts (+1 -1)
📝 packages/lib/api/deleteField.ts (+2 -11)
📝 packages/lib/api/deleteRecipient.ts (+2 -6)
📝 packages/lib/helpers/index.ts (+2 -1)
➕ packages/lib/helpers/utils.ts (+3 -0)

📄 Description

Refactor of code:

Replace concatenation using '+' operator to template literals to make code more readable
Refactor apis and remove unused code
Replaced anchorId with anchorSelect since anchorId is deprecated in react-tooltip package

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/377 **Author:** [@Dhoni77](https://github.com/Dhoni77) **Created:** 9/15/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `refactor/code` --- ### 📝 Commits (4) - [`9ed3364`](https://github.com/documenso/documenso/commit/9ed3364af6748d94aee26cefdebe3d27174343b7) Use template literals to concatenate strings to make code more readable - [`52aa9cd`](https://github.com/documenso/documenso/commit/52aa9cd2dad596b9852524e070c610d05ea3bec2) Refactor apis - [`f2b0884`](https://github.com/documenso/documenso/commit/f2b08848b5ece94247f67c1cb06af8075f9b6e23) Improve logic to delete recipient - [`2490848`](https://github.com/documenso/documenso/commit/24908483a196a771a420caa9c17c685f7342645d) Added utility to serialize data ### 📊 Changes **16 files changed** (+58 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/editor/pdf-editor.tsx` (+3 -5) 📝 `apps/web/components/navigation.tsx` (+1 -1) 📝 `apps/web/pages/api/documents/[id].ts` (+1 -2) 📝 `apps/web/pages/api/documents/[id]/fields/[fid].ts` (+0 -6) 📝 `apps/web/pages/api/documents/[id]/recipients/[rid].ts` (+1 -6) 📝 `apps/web/pages/documents.tsx` (+16 -16) 📝 `apps/web/pages/documents/[id]/index.tsx` (+5 -5) 📝 `apps/web/pages/documents/[id]/recipients.tsx` (+11 -19) 📝 `apps/web/pages/documents/[id]/sign.tsx` (+4 -3) 📝 `apps/web/pages/documents/[id]/signed.tsx` (+5 -7) 📝 `packages/lib/api/createOrUpdateField.ts` (+1 -1) 📝 `packages/lib/api/createOrUpdateRecipient.ts` (+1 -1) 📝 `packages/lib/api/deleteField.ts` (+2 -11) 📝 `packages/lib/api/deleteRecipient.ts` (+2 -6) 📝 `packages/lib/helpers/index.ts` (+2 -1) ➕ `packages/lib/helpers/utils.ts` (+3 -0) </details> ### 📄 Description Refactor of code: - Replace concatenation using '+' operator to template literals to make code more readable - Refactor apis and remove unused code - Replaced anchorId with **anchorSelect** since anchorId is deprecated in react-tooltip package --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:31:03 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#924

No description provided.

Rows
Columns