starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[GH-ISSUE #1643] FEATURE REQUEST: disable Login Option and directly direct to OIDC #465

New issue

Closed

opened 2026-02-26 18:47:09 +03:00 by kerem · 5 comments

kerem commented

2026-02-26 18:47:09 +03:00

Owner

Originally created by @celevra on GitHub (Feb 8, 2025).
Original GitHub issue: https://github.com/documenso/documenso/issues/1643

Hi,

if OIDC is configured and working there should be an option to disable the internal Login and directly direct to the OIDC provider.

regards

Celevra

Originally created by @celevra on GitHub (Feb 8, 2025). Original GitHub issue: https://github.com/documenso/documenso/issues/1643 Hi, if OIDC is configured and working there should be an option to disable the internal Login and directly direct to the OIDC provider. regards Celevra

kerem

2026-02-26 18:47:09 +03:00

closed this issue
added the
Stale

status: triage
labels

kerem commented

2026-02-26 18:47:10 +03:00

Author

Owner

@MohdSaquib114 commented on GitHub (Feb 8, 2025):

Hi, I'd like to work on this issue. Also, is there any additional information or specific requirements I should be aware of? Thanks!

@MohdSaquib114 commented on GitHub (Feb 8, 2025): Hi, I'd like to work on this issue. Also, is there any additional information or specific requirements I should be aware of? Thanks!

kerem commented

2026-02-26 18:47:10 +03:00

Author

Owner

@celevra commented on GitHub (Feb 8, 2025):

@MohdSaquib114 thank you. Nothing i can think of, if oidc is the default login method no login form is needed and also no need for the oidc button, in an event of no valid user session oidc workflow can be started without a click

@celevra commented on GitHub (Feb 8, 2025): @MohdSaquib114 thank you. Nothing i can think of, if oidc is the default login method no login form is needed and also no need for the oidc button, in an event of no valid user session oidc workflow can be started without a click

kerem commented

2026-02-26 18:47:10 +03:00

Author

Owner

@MohdSaquib114 commented on GitHub (Feb 9, 2025):

Hey @celevra! 👋

I came up with this solution for the feature request:

useEffect(() => {
  if (!isOIDCDefault || !isOIDCSSOEnabled) return;

  if (status === 'unauthenticated') {
    signIn('oidc', { callbackUrl }).catch(() =>
      toast({
        title: 'OIDC Login Failed',
        description: 'We encountered an error while attempting to sign you in.',
        variant: 'destructive',
      })
    );
  }
}, [isOIDCDefault, isOIDCSSOEnabled, callbackUrl, toast, status]);

Approach Used:

Optimized Execution – Runs only when OIDC is the default and enabled.
Session Validation – Automatically triggers OIDC login if the user is unauthenticated.
Robust Error Handling – Displays a toast notification if the login attempt fails.

I'm new to open source, I'd love to know if this approach is correct or if there's anything I should improve. Any feedback would be really helpful! 😊🚀

@MohdSaquib114 commented on GitHub (Feb 9, 2025): Hey @celevra! 👋 I came up with this solution for the feature request: ```tsx useEffect(() => { if (!isOIDCDefault || !isOIDCSSOEnabled) return; if (status === 'unauthenticated') { signIn('oidc', { callbackUrl }).catch(() => toast({ title: 'OIDC Login Failed', description: 'We encountered an error while attempting to sign you in.', variant: 'destructive', }) ); } }, [isOIDCDefault, isOIDCSSOEnabled, callbackUrl, toast, status]); ``` ### Approach Used: 1. **Optimized Execution** – Runs only when OIDC is the default and enabled. 2. **Session Validation** – Automatically triggers OIDC login if the user is unauthenticated. 3. **Robust Error Handling** – Displays a toast notification if the login attempt fails. I'm new to open source, I'd love to know if this approach is correct or if there's anything I should improve. Any feedback would be really helpful! 😊🚀

kerem commented

2026-02-26 18:47:10 +03:00

Author

Owner

@celevra commented on GitHub (Feb 9, 2025):

sounds good, think you have to create a pull request.
In which file do i have to put this code? than i can test it

@celevra commented on GitHub (Feb 9, 2025): sounds good, think you have to create a pull request. In which file do i have to put this code? than i can test it

kerem commented

2026-02-26 18:47:10 +03:00

Author

Owner

@MohdSaquib114 commented on GitHub (Feb 9, 2025):

In web/src/components/form/signinl.tsx

@MohdSaquib114 commented on GitHub (Feb 9, 2025): In web/src/components/form/signinl.tsx

kerem referenced this issue

2026-02-26 19:31:21 +03:00

[PR #466] [MERGED] fix: safari pdf overflow issue fixed #990

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#465

No description provided.

Rows
Columns