starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1456] [MERGED] feat: additional valid password #1643

New issue

Closed

opened 2026-02-26 19:34:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1456
Author: @Dun-sin
Created: 11/9/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @dguyen

Base: main ← Head: dun-sin/additional-valid-passwort-1374

📝 Commits (3)

a10116d fix: error message not showing when password contains personal info
1a4cb55 feat: regex doesn't apply to longer passwords
af85b7d Merge branch 'main' into dun-sin/additional-valid-passwort-1374

📊 Changes

10 files changed (+30 additions, -26 deletions)

View changed files

📝 apps/openpage-api/app/growth/total-users/route.ts (+1 -1)
📝 apps/openpage-api/lib/cors.ts (+4 -4)
📝 apps/web/src/app/(signing)/sign/[token]/dropdown-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/name-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/number-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/text-field.tsx (+5 -5)
📝 apps/web/src/components/(dashboard)/avatar/stack-avatar.tsx (+1 -4)
📝 apps/web/src/components/forms/v2/signup.tsx (+1 -0)
📝 packages/trpc/server/auth-router/schema.ts (+13 -7)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+2 -2)

📄 Description

Description

When the password length's is more than 25, regex check doesn't work

fixes #1374

Changes Made

added the missing path for passwords that was preventing the error message from showing if the password contains a personal information
using the refine method in zod to check if the password length is more than 25 if it's not we don't apply the regex check

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Enhanced error messaging for password validation in the signup form.
- Updated password complexity requirements, allowing longer passwords to bypass some checks while maintaining minimum standards.
Bug Fixes
- Improved clarity of error messages related to password fields in the signup process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1456 **Author:** [@Dun-sin](https://github.com/Dun-sin) **Created:** 11/9/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `dun-sin/additional-valid-passwort-1374` --- ### 📝 Commits (3) - [`a10116d`](https://github.com/documenso/documenso/commit/a10116ddee19b6081dbc7d13831af750a3e89f71) fix: error message not showing when password contains personal info - [`1a4cb55`](https://github.com/documenso/documenso/commit/1a4cb555fa32c635136a3bdb6f305ce9f65466b1) feat: regex doesn't apply to longer passwords - [`af85b7d`](https://github.com/documenso/documenso/commit/af85b7d97999d245652029a9808c204300b0b286) Merge branch 'main' into dun-sin/additional-valid-passwort-1374 ### 📊 Changes **10 files changed** (+30 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `apps/openpage-api/app/growth/total-users/route.ts` (+1 -1) 📝 `apps/openpage-api/lib/cors.ts` (+4 -4) 📝 `apps/web/src/app/(signing)/sign/[token]/dropdown-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/name-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/number-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/text-field.tsx` (+5 -5) 📝 `apps/web/src/components/(dashboard)/avatar/stack-avatar.tsx` (+1 -4) 📝 `apps/web/src/components/forms/v2/signup.tsx` (+1 -0) 📝 `packages/trpc/server/auth-router/schema.ts` (+13 -7) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+2 -2) </details> ### 📄 Description ## Description When the password length's is more than 25, regex check doesn't work ## Related Issue fixes #1374   ## Changes Made   - added the missing path for passwords that was preventing the error message from showing if the password contains a personal information - using the refine method in zod to check if the password length is more than 25 if it's not we don't apply the regex check ## Checklist   - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit - **New Features** - Enhanced error messaging for password validation in the signup form. - Updated password complexity requirements, allowing longer passwords to bypass some checks while maintaining minimum standards. - **Bug Fixes** - Improved clarity of error messages related to password fields in the signup process.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:08 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:59 +03:00

[PR #1645] [CLOSED] feat(oidc): disable login and redirect directly to OIDC (#1643) #1766

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1643

No description provided.

Rows
Columns