starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-24 21:36:01 +03:00

js file #2380

New issue

Open

opened 2026-02-26 20:33:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2543
Author: @ropelletier
Created: 2/25/2026
Status: 🔄 Open

Base: main ← Head: main

📝 Commits (6)

1b94fa6 feat: add fieldId to all field types
7e628b8 feat: add custom CSS/JS URL support
89edeaf fix: use fieldMeta instead of meta in embedding router schemas
2bd7114 Merge branch 'fix/fieldid-fieldmeta'
e1ad7d7 Merge branch 'documenso:main' into main
7f889d8 Merge branch 'documenso:main' into main

📊 Changes

37 files changed (+682 additions, -44 deletions)

View changed files

📝 .env.example (+6 -0)
📝 .gitignore (+4 -0)
📝 apps/remix/app/components/dialogs/sign-field-number-dialog.tsx (+3 -2)
📝 apps/remix/app/components/dialogs/sign-field-text-dialog.tsx (+3 -2)
📝 apps/remix/app/components/forms/editor/editor-field-checkbox-form.tsx (+22 -4)
📝 apps/remix/app/components/forms/editor/editor-field-date-form.tsx (+30 -1)
📝 apps/remix/app/components/forms/editor/editor-field-dropdown-form.tsx (+19 -1)
📝 apps/remix/app/components/forms/editor/editor-field-email-form.tsx (+30 -1)
📝 apps/remix/app/components/forms/editor/editor-field-initials-form.tsx (+30 -1)
📝 apps/remix/app/components/forms/editor/editor-field-name-form.tsx (+30 -1)
📝 apps/remix/app/components/forms/editor/editor-field-number-form.tsx (+23 -1)
📝 apps/remix/app/components/forms/editor/editor-field-radio-form.tsx (+20 -2)
📝 apps/remix/app/components/forms/editor/editor-field-signature-form.tsx (+31 -3)
📝 apps/remix/app/components/forms/editor/editor-field-text-form.tsx (+18 -0)
📝 apps/remix/app/components/general/document-signing/document-signing-text-field.tsx (+4 -2)
📝 apps/remix/app/root.tsx (+10 -1)
📝 apps/remix/app/utils/field-signing/number-field.ts (+14 -7)
📝 apps/remix/app/utils/field-signing/text-field.ts (+16 -7)
📝 packages/lib/constants/app.ts (+4 -0)
📝 packages/lib/translations/de/web.po (+27 -0)

...and 17 more files

📄 Description

Description

Adds a Field ID input to each field in advanced settings drawer, for the purpose of being able to more uniquely identity each field when pot-processing the webhook data as well as when prefilling the fields.

Also adds .env variables for adding a custom css and/or js file to the header.

This solves the problem of not being able to elegantly identify the fields during the post-processing of webhook data.

Should fix #2329

Testing Performed

I tested that the each field has the new Field Id input in each of their respective drawers.
Tested that the field id is saved in the fieldMeta column of the database and then replicated when a document is made from the template.
Tested that the webhook data contains the new fieldId information is the data.
Tested that when I do api calls for the template/document, that the new fieldId information is in the fieldMeta data.

Checklist

[x ] I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
[x ] I have followed the project's coding style guidelines.
[x ] I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2543 **Author:** [@ropelletier](https://github.com/ropelletier) **Created:** 2/25/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (6) - [`1b94fa6`](https://github.com/documenso/documenso/commit/1b94fa6ece631277e68979b72be5ef161d7678f0) feat: add fieldId to all field types - [`7e628b8`](https://github.com/documenso/documenso/commit/7e628b8ce6583b53f9df28a7f51baf555eeb9007) feat: add custom CSS/JS URL support - [`89edeaf`](https://github.com/documenso/documenso/commit/89edeaf20f9c57c5696604680f35d4c2e222916c) fix: use fieldMeta instead of meta in embedding router schemas - [`2bd7114`](https://github.com/documenso/documenso/commit/2bd711431f0a462c56ac945a6e420fde54e75e1f) Merge branch 'fix/fieldid-fieldmeta' - [`e1ad7d7`](https://github.com/documenso/documenso/commit/e1ad7d7ca063c49c19bae2bad5b00be6404d2791) Merge branch 'documenso:main' into main - [`7f889d8`](https://github.com/documenso/documenso/commit/7f889d8ca2bf8add5f7a80456052883210133605) Merge branch 'documenso:main' into main ### 📊 Changes **37 files changed** (+682 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+6 -0) 📝 `.gitignore` (+4 -0) 📝 `apps/remix/app/components/dialogs/sign-field-number-dialog.tsx` (+3 -2) 📝 `apps/remix/app/components/dialogs/sign-field-text-dialog.tsx` (+3 -2) 📝 `apps/remix/app/components/forms/editor/editor-field-checkbox-form.tsx` (+22 -4) 📝 `apps/remix/app/components/forms/editor/editor-field-date-form.tsx` (+30 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-dropdown-form.tsx` (+19 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-email-form.tsx` (+30 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-initials-form.tsx` (+30 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-name-form.tsx` (+30 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-number-form.tsx` (+23 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-radio-form.tsx` (+20 -2) 📝 `apps/remix/app/components/forms/editor/editor-field-signature-form.tsx` (+31 -3) 📝 `apps/remix/app/components/forms/editor/editor-field-text-form.tsx` (+18 -0) 📝 `apps/remix/app/components/general/document-signing/document-signing-text-field.tsx` (+4 -2) 📝 `apps/remix/app/root.tsx` (+10 -1) 📝 `apps/remix/app/utils/field-signing/number-field.ts` (+14 -7) 📝 `apps/remix/app/utils/field-signing/text-field.ts` (+16 -7) 📝 `packages/lib/constants/app.ts` (+4 -0) 📝 `packages/lib/translations/de/web.po` (+27 -0) _...and 17 more files_ </details> ### 📄 Description ## Description  Adds a Field ID input to each field in advanced settings drawer, for the purpose of being able to more uniquely identity each field when pot-processing the webhook data as well as when prefilling the fields. Also adds .env variables for adding a custom css and/or js file to the header.  This solves the problem of not being able to elegantly identify the fields during the post-processing of webhook data. ## Related Issue   Should fix #2329 ## Testing Performed I tested that the each field has the new Field Id input in each of their respective drawers. Tested that the field id is saved in the fieldMeta column of the database and then replicated when a document is made from the template. Tested that the webhook data contains the new fieldId information is the data. Tested that when I do api calls for the template/document, that the new fieldId information is in the fieldMeta data. ## Checklist   - [x ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x ] I have followed the project's coding style guidelines. - [x ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-26 20:33:37 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2380

No description provided.

Rows
Columns