[PR #2476] [CLOSED] fix: guard send dialogs against org claim races #2329

Closed
opened 2026-02-26 20:33:25 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2476
Author: @ephraimduncan
Created: 2/11/2026
Status: Closed

Base: mainHead: fix/recipients-send-500


📝 Commits (1)

  • 47e0fa4 fix: guard send dialogs against org claim races

📊 Changes

2 files changed (+23 additions, -11 deletions)

View changed files

📝 apps/remix/app/components/dialogs/envelope-distribute-dialog.tsx (+12 -6)
📝 packages/ui/primitives/document-flow/add-subject.tsx (+11 -5)

📄 Description

Description

Fix intermittent 500 errors when opening send flows before organisation claim data is fully available.

Changes Made

  • Guard org email-domain checks in the modern send dialog to avoid null-access during first render.
  • Apply the same guard and conditional sender-email lookup in the legacy editor

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2476 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 2/11/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/recipients-send-500` --- ### 📝 Commits (1) - [`47e0fa4`](https://github.com/documenso/documenso/commit/47e0fa40cad7b72b278a9fb11b773b7f649b6fa3) fix: guard send dialogs against org claim races ### 📊 Changes **2 files changed** (+23 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/envelope-distribute-dialog.tsx` (+12 -6) 📝 `packages/ui/primitives/document-flow/add-subject.tsx` (+11 -5) </details> ### 📄 Description ## Description Fix intermittent 500 errors when opening send flows before organisation claim data is fully available. ## Changes Made - Guard org email-domain checks in the modern send dialog to avoid null-access during first render. - Apply the same guard and conditional sender-email lookup in the legacy editor ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:33:25 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#2329
No description provided.