starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #2355] refactor: avoid recipient color duplication #2245

New issue

Open

opened 2026-02-26 20:33:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2355
Author: @tedliang
Created: 1/3/2026
Status: 🔄 Open

Base: main ← Head: refactor/recipient-dynamic-class

📝 Commits (1)

e7e08f4 refactor: avoid recipient color duplication

📊 Changes

16 files changed (+110 additions, -202 deletions)

View changed files

📝 apps/remix/app/components/embed/authoring/configure-fields-view.tsx (+2 -4)
📝 apps/remix/app/components/general/document-signing/document-signing-field-container.tsx (+2 -4)
📝 apps/remix/app/components/general/envelope-editor/envelope-editor-fields-drag-drop.tsx (+8 -14)
📝 apps/remix/app/components/general/envelope-editor/envelope-recipient-selector.tsx (+4 -12)
📝 apps/remix/app/components/general/envelope-signing/envelope-signer-page-renderer.tsx (+5 -8)
📝 apps/remix/tailwind.config.ts (+2 -3)
📝 packages/lib/client-only/providers/envelope-editor-provider.tsx (+3 -10)
📝 packages/lib/client-only/providers/envelope-render-provider.tsx (+2 -8)
📝 packages/lib/universal/field-renderer/field-generic-items.ts (+3 -3)
📝 packages/ui/components/document/document-read-only-fields.tsx (+1 -4)
📝 packages/ui/lib/recipient-colors.ts (+62 -103)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+2 -4)
📝 packages/ui/primitives/document-flow/field-item.tsx (+2 -2)
📝 packages/ui/primitives/recipient-selector.tsx (+4 -12)
📝 packages/ui/primitives/template-flow/add-template-fields.tsx (+5 -10)
📝 packages/ui/tailwind.config.cjs (+3 -1)

📄 Description

Description

avoid recipient color duplication

N/A

Changes Made

Avoid recipient color duplication in TS
Simplify getRecipientColorStyles usage
Fix typo combox-> combo
Uttilize tailwind reusable configuration

Testing Performed

Tested on Chrome.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Recipient color can be overridden by custom css in embed mode:

:root, .dark-mode-disabled {
  --ring: 235 100% 50%;
  --recipient-green: 235 100% 50%;
  --recipient-blue: 100 48% 55%;
}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2355 **Author:** [@tedliang](https://github.com/tedliang) **Created:** 1/3/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `refactor/recipient-dynamic-class` --- ### 📝 Commits (1) - [`e7e08f4`](https://github.com/documenso/documenso/commit/e7e08f4f56e690a6757c189ff91f41a68255ebfa) refactor: avoid recipient color duplication ### 📊 Changes **16 files changed** (+110 additions, -202 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/embed/authoring/configure-fields-view.tsx` (+2 -4) 📝 `apps/remix/app/components/general/document-signing/document-signing-field-container.tsx` (+2 -4) 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-fields-drag-drop.tsx` (+8 -14) 📝 `apps/remix/app/components/general/envelope-editor/envelope-recipient-selector.tsx` (+4 -12) 📝 `apps/remix/app/components/general/envelope-signing/envelope-signer-page-renderer.tsx` (+5 -8) 📝 `apps/remix/tailwind.config.ts` (+2 -3) 📝 `packages/lib/client-only/providers/envelope-editor-provider.tsx` (+3 -10) 📝 `packages/lib/client-only/providers/envelope-render-provider.tsx` (+2 -8) 📝 `packages/lib/universal/field-renderer/field-generic-items.ts` (+3 -3) 📝 `packages/ui/components/document/document-read-only-fields.tsx` (+1 -4) 📝 `packages/ui/lib/recipient-colors.ts` (+62 -103) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+2 -4) 📝 `packages/ui/primitives/document-flow/field-item.tsx` (+2 -2) 📝 `packages/ui/primitives/recipient-selector.tsx` (+4 -12) 📝 `packages/ui/primitives/template-flow/add-template-fields.tsx` (+5 -10) 📝 `packages/ui/tailwind.config.cjs` (+3 -1) </details> ### 📄 Description ## Description avoid recipient color duplication ## Related Issue   N/A ## Changes Made   - Avoid recipient color duplication in TS - Simplify getRecipientColorStyles usage - Fix typo combox-> combo - Uttilize tailwind reusable configuration ## Testing Performed   - Tested on Chrome. ## Checklist   - [X] I have tested these changes locally and they work as expected. - [X] I have added/updated tests that prove the effectiveness of these changes. - [X] I have updated the documentation to reflect these changes, if applicable. - [X] I have followed the project's coding style guidelines. - [X] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   Recipient color can be overridden by custom css in embed mode: ``` :root, .dark-mode-disabled { --ring: 235 100% 50%; --recipient-green: 235 100% 50%; --recipient-blue: 100 48% 55%; } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-26 20:33:03 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2245

No description provided.

Rows
Columns