[PR #2508] feat: add faceted table toolbars and multi-value filters #2355

New issue

Open

opened 2026-02-26 20:33:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2508
Author: @ephraimduncan
Created: 2/16/2026
Status: 🔄 Open

Base: main ← Head: feat/table-toolbar-filters

📝 Commits (3)

335fee0 feat: add faceted table toolbars and multi-value filters
921e0a0 perf: reduce rerenders and async waterfalls in document tables
1c12aed refactor: simplify template type filter to single-value enum

📊 Changes

23 files changed (+1080 additions, -455 deletions)

View changed files

➖ apps/remix/app/components/forms/search-param-selector.tsx (+0 -51)
➖ apps/remix/app/components/general/document/document-search.tsx (+0 -48)
➖ apps/remix/app/components/general/period-selector.tsx (+0 -70)
📝 apps/remix/app/components/general/template/template-page-view-documents-table.tsx (+22 -66)
➖ apps/remix/app/components/tables/documents-table-sender-filter.tsx (+0 -66)
➕ apps/remix/app/components/tables/documents-table-toolbar.tsx (+196 -0)
➕ apps/remix/app/components/tables/table-toolbar.constants.ts (+21 -0)
➕ apps/remix/app/components/tables/template-documents-table-toolbar.tsx (+206 -0)
➕ apps/remix/app/components/tables/templates-table-toolbar.tsx (+131 -0)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents._index.tsx (+45 -84)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates._index.tsx (+26 -4)
📝 packages/app-tests/e2e/fixtures/documents.ts (+18 -3)
📝 packages/app-tests/e2e/teams/team-documents.spec.ts (+18 -3)
📝 packages/app-tests/e2e/templates/manage-templates.spec.ts (+52 -1)
📝 packages/lib/client-only/hooks/use-update-search-params.ts (+30 -12)
📝 packages/lib/server-only/document/find-documents.ts (+69 -32)
📝 packages/lib/server-only/document/get-stats.ts (+1 -1)
📝 packages/lib/server-only/template/find-templates.ts (+26 -3)
📝 packages/lib/utils/params.ts (+24 -5)
📝 packages/trpc/server/document-router/find-documents-internal.ts (+4 -1)

...and 3 more files

📄 Description

Description

Introduces faceted table toolbars and multi-value filters for documents and templates tables, including reusable filter primitives and server/query updates to support the new filter model.

Demo

06-template-detail-source-popover-selected

Changes Made

Added dedicated toolbar components for documents, templates, and template detail document tables.
Added shared table toolbar constants and a new data-table-faceted-filter primitive.
Removed legacy search/period/sender filter components that were replaced by faceted toolbars.
Updated server-side query/schema/search-param handling for multi-value filters.
Updated E2E fixtures/specs for team documents and manage templates filter behavior.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2508 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 2/16/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/table-toolbar-filters` --- ### 📝 Commits (3) - [`335fee0`](https://github.com/documenso/documenso/commit/335fee09a94ff1e04e3371278fcc4856b9bb2a04) feat: add faceted table toolbars and multi-value filters - [`921e0a0`](https://github.com/documenso/documenso/commit/921e0a0de619cce6075c4a59a31ef7f15f609f5d) perf: reduce rerenders and async waterfalls in document tables - [`1c12aed`](https://github.com/documenso/documenso/commit/1c12aed35ed0e47d6156b065021330d453c75881) refactor: simplify template type filter to single-value enum ### 📊 Changes **23 files changed** (+1080 additions, -455 deletions) <details> <summary>View changed files</summary> ➖ `apps/remix/app/components/forms/search-param-selector.tsx` (+0 -51) ➖ `apps/remix/app/components/general/document/document-search.tsx` (+0 -48) ➖ `apps/remix/app/components/general/period-selector.tsx` (+0 -70) 📝 `apps/remix/app/components/general/template/template-page-view-documents-table.tsx` (+22 -66) ➖ `apps/remix/app/components/tables/documents-table-sender-filter.tsx` (+0 -66) ➕ `apps/remix/app/components/tables/documents-table-toolbar.tsx` (+196 -0) ➕ `apps/remix/app/components/tables/table-toolbar.constants.ts` (+21 -0) ➕ `apps/remix/app/components/tables/template-documents-table-toolbar.tsx` (+206 -0) ➕ `apps/remix/app/components/tables/templates-table-toolbar.tsx` (+131 -0) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents._index.tsx` (+45 -84) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates._index.tsx` (+26 -4) 📝 `packages/app-tests/e2e/fixtures/documents.ts` (+18 -3) 📝 `packages/app-tests/e2e/teams/team-documents.spec.ts` (+18 -3) 📝 `packages/app-tests/e2e/templates/manage-templates.spec.ts` (+52 -1) 📝 `packages/lib/client-only/hooks/use-update-search-params.ts` (+30 -12) 📝 `packages/lib/server-only/document/find-documents.ts` (+69 -32) 📝 `packages/lib/server-only/document/get-stats.ts` (+1 -1) 📝 `packages/lib/server-only/template/find-templates.ts` (+26 -3) 📝 `packages/lib/utils/params.ts` (+24 -5) 📝 `packages/trpc/server/document-router/find-documents-internal.ts` (+4 -1) _...and 3 more files_ </details> ### 📄 Description ## Description Introduces faceted table toolbars and multi-value filters for documents and templates tables, including reusable filter primitives and server/query updates to support the new filter model. ## Demo <img width="776" height="372" alt="02-documents-status-popover-selected" src="https://github.com/user-attachments/assets/15621702-611a-4653-8766-b4ee6d6bfb18" /> <img width="586" height="287" alt="05-templates-type-popover-selected" src="https://github.com/user-attachments/assets/6d2ccf48-d28b-4b97-b85d-4dcbdc518e87" /> <img width="801" height="274" alt="06-template-detail-source-popover-selected" src="https://github.com/user-attachments/assets/566ee699-d1e4-4f79-9bf1-3cf5dc36bc32" /> ## Changes Made - Added dedicated toolbar components for documents, templates, and template detail document tables. - Added shared table toolbar constants and a new `data-table-faceted-filter` primitive. - Removed legacy search/period/sender filter components that were replaced by faceted toolbars. - Updated server-side query/schema/search-param handling for multi-value filters. - Updated E2E fixtures/specs for team documents and manage templates filter behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-26 20:33:31 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2355

No description provided.

Rows
Columns