starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #2245] fix: prevent layout shift on signup form when validation errors appear (fixes #2235) #2150

New issue

Open

opened 2026-02-26 20:32:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2245
Author: @eeshm
Created: 11/25/2025
Status: 🔄 Open

Base: main ← Head: fix/signup-layout-shift-clean

📝 Commits (1)

5db3b44 fix: prevent signup form layout shift by using min-h instead of fixed h (fixes #2235)

📊 Changes

1 file changed (+16 additions, -16 deletions)

View changed files

📝 apps/remix/app/components/forms/signup.tsx (+16 -16)

📄 Description

Description

This PR fixes a layout shift on the signup form caused by fixed height fieldsets.
When validation errors appear below the input fields, the content grows beyond the fixed height, causing a sudden UI jump/glitch.

Fixes #2235

Changes Made

Replaced fixed height classes in the signup form with minimum heights:

h-[550px] → min-h-[550px]
h-[650px] → min-h-[650px]

Ensured the form expands naturally when validation errors appear, preventing layout shifts.

Before :
Screenshot 2025-11-25 203324

After:

Testing Performed

Submit the form with empty fields → validation errors appear smoothly, no UI jump
Responsive/mobile view → layout remains stable

Checklist

I have tested these changes locally and they work as expected.

Additional Notes

Some minor CSS classes were reordered accidentally, can be ignored.
Main fix is the replacement of fixed heights from h-[550px] and h-[650px] to min-h-[550px] and min-h-[650px].

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2245 **Author:** [@eeshm](https://github.com/eeshm) **Created:** 11/25/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/signup-layout-shift-clean` --- ### 📝 Commits (1) - [`5db3b44`](https://github.com/documenso/documenso/commit/5db3b44f5dce112a811b6f4732891da7e6b78486) fix: prevent signup form layout shift by using min-h instead of fixed h (fixes #2235) ### 📊 Changes **1 file changed** (+16 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/forms/signup.tsx` (+16 -16) </details> ### 📄 Description ## Description This PR fixes a layout shift on the signup form caused by fixed height fieldsets. When validation errors appear below the input fields, the content grows beyond the fixed height, causing a sudden UI jump/glitch. ## Related Issue Fixes #2235 ## Changes Made Replaced fixed height classes in the signup form with minimum heights: h-[550px] → min-h-[550px] h-[650px] → min-h-[650px] Ensured the form expands naturally when validation errors appear, preventing layout shifts. Before : <img width="1874" height="966" alt="Screenshot 2025-11-25 203324" src="https://github.com/user-attachments/assets/71dfe563-dc63-4cf9-9612-ed7f9e13c2d2" /> After: [ <img width="1915" height="894" alt="Screenshot 2025-11-25 203428" src="https://github.com/user-attachments/assets/c689be58-df3d-481e-bb41-028f55b607ac" /> ](url) ## Testing Performed - Submit the form with empty fields → validation errors appear smoothly, no UI jump - Responsive/mobile view → layout remains stable ## Checklist - [x] I have tested these changes locally and they work as expected. ## Additional Notes - Some minor CSS classes were reordered accidentally, can be ignored. - Main fix is the replacement of fixed heights from h-[550px] and h-[650px] to min-h-[550px] and min-h-[650px]. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-26 20:32:38 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2150

No description provided.

Rows
Columns