starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[GH-ISSUE #724] While setting the project on windows operating system, There were some some wierd prettier errors on every file #212

New issue

Closed

opened 2026-02-26 18:45:54 +03:00 by kerem · 5 comments

kerem commented

2026-02-26 18:45:54 +03:00

Owner

Originally created by @kritarth2121 on GitHub (Dec 3, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/724

Improvement Description

No response

Rationale

No response

Proposed Solution

No response

Alternatives (optional)

No response

Additional Context

No response

Please check the boxes that apply to this improvement suggestion.

I have searched the existing issues and improvement suggestions to avoid duplication.
I have provided a clear description of the improvement being suggested.
I have explained the rationale behind this improvement.
I have included any relevant technical details or design suggestions.
I understand that this is a suggestion and that there is no guarantee of implementation.

Originally created by @kritarth2121 on GitHub (Dec 3, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/724 ### Improvement Description _No response_ ### Rationale _No response_ ### Proposed Solution _No response_ ### Alternatives (optional) _No response_ ### Additional Context _No response_ ### Please check the boxes that apply to this improvement suggestion. - [ ] I have searched the existing issues and improvement suggestions to avoid duplication. - [ ] I have provided a clear description of the improvement being suggested. - [ ] I have explained the rationale behind this improvement. - [ ] I have included any relevant technical details or design suggestions. - [ ] I understand that this is a suggestion and that there is no guarantee of implementation.

kerem closed this issue

2026-02-26 18:45:54 +03:00

kerem commented

2026-02-26 18:45:55 +03:00

Author

Owner

@kritarth2121 commented on GitHub (Dec 3, 2023):

@kritarth2121 commented on GitHub (Dec 3, 2023): ![Screenshot 2023-12-04 000334](https://github.com/documenso/documenso/assets/44065192/9b37c773-ac96-4026-ba59-8466b2bee324)

kerem commented

2026-02-26 18:45:55 +03:00

Author

Owner

@Mythie commented on GitHub (Dec 4, 2023):

Right this will be because windows is using CRLF while we use LF, we have an .editorconfig file for this but it seems you may not have the extension that enables this for VSCode.

Disabling the rule as per your pull request isn't the solution either since it'll introduce a ton of changes in pull requests depending on the end of line configured for each editor as well.

@Mythie commented on GitHub (Dec 4, 2023): Right this will be because windows is using CRLF while we use LF, we have an `.editorconfig` file for this but it seems you may not have the extension that enables this for VSCode. Disabling the rule as per your pull request isn't the solution either since it'll introduce a ton of changes in pull requests depending on the end of line configured for each editor as well.

kerem commented

2026-02-26 18:45:55 +03:00

Author

Owner

@kritarth2121 commented on GitHub (Dec 4, 2023):

Right this will be because windows is using CRLF while we use LF, we have an .editorconfig file for this but it seems you may not have the extension that enables this for VSCode.

Disabling the rule as per your pull request isn't the solution either since it'll introduce a ton of changes in pull requests depending on the end of line configured for each editor as well.

Hi @Mythie, Thanks for reply, I got you,

I am asking, like if you need a software engineer, I am willing to work for documenso,

I have experience of 4+ years in Full Stack development.

I can work in your time zone and start immediately.

This is my portfolio
https://kritarth.netlify.app/

Lets connect
Thanks

@kritarth2121 commented on GitHub (Dec 4, 2023): > Right this will be because windows is using CRLF while we use LF, we have an `.editorconfig` file for this but it seems you may not have the extension that enables this for VSCode. > > Disabling the rule as per your pull request isn't the solution either since it'll introduce a ton of changes in pull requests depending on the end of line configured for each editor as well. Hi @Mythie, Thanks for reply, I got you, I am asking, like if you need a software engineer, I am willing to work for documenso, I have experience of 4+ years in Full Stack development. I am quite good in the following tech stacks - HTML | CSS | JavaScript | TypeScript | React Js | Angular JS | Next Js | Redux | Node | Express | Adonish | MySQL | Postgresql | MongoDB I can work in your time zone and start immediately. This is my portfolio https://kritarth.netlify.app/ Lets connect Thanks

kerem commented

2026-02-26 18:45:55 +03:00

Author

Owner

@kritarth2121 commented on GitHub (Dec 4, 2023):

Right this will be because windows is using CRLF while we use LF, we have an .editorconfig file for this but it seems you may not have the extension that enables this for VSCode.

Disabling the rule as per your pull request isn't the solution either since it'll introduce a ton of changes in pull requests depending on the end of line configured for each editor as well.

In my case, it didn't introduce any extra changes with this fix #725 , as I was just disabling the prettier check at the end of the line.

@kritarth2121 commented on GitHub (Dec 4, 2023): > Right this will be because windows is using CRLF while we use LF, we have an `.editorconfig` file for this but it seems you may not have the extension that enables this for VSCode. > > Disabling the rule as per your pull request isn't the solution either since it'll introduce a ton of changes in pull requests depending on the end of line configured for each editor as well. In my case, it didn't introduce any extra changes with this fix #725 , as I was just disabling the prettier check at the end of the line.

kerem commented

2026-02-26 18:45:55 +03:00

Author

Owner

@Mythie commented on GitHub (Dec 4, 2023):

I am asking, like if you need a software engineer, I am willing to work for documenso,

We're capped out on staff at the moment sorry! Our team is now bottlenecked on my ability to review and delegate so we definitely can't take on anyone else 🫡

In my case, it didn't introduce any extra changes with this fix https://github.com/documenso/documenso/pull/725 , as I was just disabling the prettier check at the end of the line.

The prettier check in that PR will cause changes with every PR depending on the contributors machine line ending preference 😅

@Mythie commented on GitHub (Dec 4, 2023): > I am asking, like if you need a software engineer, I am willing to work for documenso, We're capped out on staff at the moment sorry! Our team is now bottlenecked on my ability to review and delegate so we definitely can't take on anyone else 🫡 > In my case, it didn't introduce any extra changes with this fix https://github.com/documenso/documenso/pull/725 , as I was just disabling the prettier check at the end of the line. The prettier check in that PR will cause changes with every PR depending on the contributors machine line ending preference 😅

kerem referenced this issue

2026-02-26 18:48:58 +03:00

[PR #212] [CLOSED] Dropzone Animation Transition #797

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#212

No description provided.

Rows
Columns