[PR #38] [MERGED] fix: improve text insertion accuracy #724

New issue

Closed

opened 2026-02-26 18:48:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:48:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/38
Author: @Mythie
Created: 4/6/2023
Status: ✅ Merged
Merged: 4/7/2023
Merged by: @ElTimuro

Base: main ← Head: fix/improve-text-insertion-accuracy

📝 Commits (1)

ee4ca01 fix: improve text insertion accuracy

📊 Changes

1 file changed (+18 additions, -9 deletions)

View changed files

📝 packages/pdf/insertTextInPDF.ts (+18 -9)

📄 Description

Previously, inserted text would appear a little off center from where the user had selected which could cause some frustration.

We improve upon this by updating the code responsible for centering the text to behave in a more accurate manner. From what I can tell it looks to be quite solid but could do with more rigorous testing with shorter and longer inputs.

You can see the improved accuracy in action here:

https://www.loom.com/share/1095fee7605c4790b8b30f573a04f0f0

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/38 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 4/6/2023 **Status:** ✅ Merged **Merged:** 4/7/2023 **Merged by:** [@ElTimuro](https://github.com/ElTimuro) **Base:** `main` ← **Head:** `fix/improve-text-insertion-accuracy` --- ### 📝 Commits (1) - [`ee4ca01`](https://github.com/documenso/documenso/commit/ee4ca018d8436d16f3657d439abab20a87ba9f01) fix: improve text insertion accuracy ### 📊 Changes **1 file changed** (+18 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/pdf/insertTextInPDF.ts` (+18 -9) </details> ### 📄 Description Previously, inserted text would appear a little off center from where the user had selected which could cause some frustration. We improve upon this by updating the code responsible for centering the text to behave in a more accurate manner. From what I can tell it looks to be quite solid but could do with more rigorous testing with shorter and longer inputs. You can see the improved accuracy in action here: https://www.loom.com/share/1095fee7605c4790b8b30f573a04f0f0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 18:48:39 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:32:01 +03:00

[PR #725] [MERGED] fix: add workspace settings for eol and tabs #1141

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#724

No description provided.

Rows
Columns