starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #2066] [CLOSED] fix: correct missing French translations for recipient role action verbs #2027

New issue

Closed

opened 2026-02-26 20:32:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2066
Author: @cyrilgrv
Created: 10/7/2025
Status: ❌ Closed

Base: main ← Head: fix/french-email-translations

📝 Commits (1)

0e7e5f0 fix: correct missing French translations for recipient role action verbs

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 packages/lib/translations/fr/web.po (+6 -6)

📄 Description

Description

This PR fixes French translation errors in automated email templates where recipient action verbs were missing, causing broken sentences.

Problem

When users receive emails in French, they see grammatically incorrect sentences like:

❌ "Veuillez sign votre document"
❌ "Vous avez initié le document qui nécessite que vous sign celui-ci"

Instead of the correct:

✅ "Veuillez signer votre document"
✅ "Vous avez initié le document qui nécessite que vous signiez celui-ci"

Root Cause

The recipient role action verbs in packages/lib/constants/recipient-roles.ts had empty French translations in packages/lib/translations/fr/web.po. These verbs are dynamically inserted into email templates via placeholders like {recipientActionVerb}.

Changes

✅ Add French translation for "Sign" → "signer"
✅ Add French translation for "Approve" → "approuver"
✅ Add French translation for "Assist" → "assister"
✅ Add French translation for "View" → "consulter"
✅ Add French translation for "CC" → "recevoir en copie"
✅ Fix verb form consistency: "Continuez" → "Continuer" to match similar translations

Testing

These translations affect all automated emails sent to document recipients when the email language is French.

Files Changed

packages/lib/translations/fr/web.po

Fixes automated email translations for French-speaking users.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2066 **Author:** [@cyrilgrv](https://github.com/cyrilgrv) **Created:** 10/7/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/french-email-translations` --- ### 📝 Commits (1) - [`0e7e5f0`](https://github.com/documenso/documenso/commit/0e7e5f010229bc72871c8810e4874c736e3712d8) fix: correct missing French translations for recipient role action verbs ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/translations/fr/web.po` (+6 -6) </details> ### 📄 Description ## Description This PR fixes French translation errors in automated email templates where recipient action verbs were missing, causing broken sentences. ## Problem When users receive emails in French, they see grammatically incorrect sentences like: - ❌ "Veuillez **sign** votre document" - ❌ "Vous avez initié le document qui nécessite que vous **sign** celui-ci" Instead of the correct: - ✅ "Veuillez **signer** votre document" - ✅ "Vous avez initié le document qui nécessite que vous **signiez** celui-ci" ## Root Cause The recipient role action verbs in `packages/lib/constants/recipient-roles.ts` had empty French translations in `packages/lib/translations/fr/web.po`. These verbs are dynamically inserted into email templates via placeholders like `{recipientActionVerb}`. ## Changes - ✅ Add French translation for "Sign" → "signer" - ✅ Add French translation for "Approve" → "approuver" - ✅ Add French translation for "Assist" → "assister" - ✅ Add French translation for "View" → "consulter" - ✅ Add French translation for "CC" → "recevoir en copie" - ✅ Fix verb form consistency: "Continuez" → "Continuer" to match similar translations ## Testing These translations affect all automated emails sent to document recipients when the email language is French. ## Files Changed - `packages/lib/translations/fr/web.po` ## Related Fixes automated email translations for French-speaking users. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:07 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2027

No description provided.

Rows
Columns