[PR #2130] [MERGED] fix(i18n): add pluralization to document details #2066

New issue

Closed

opened 2026-02-26 20:32:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2130
Author: @mKoonrad
Created: 11/4/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @dguyen

Base: main ← Head: fix(i18n)/2122-add-pluralization

📝 Commits (4)

0e588ff fix(i18n): add pluralization to document details
976f199 chore: re-run tests
f132797 fix(i18n): add pluralization to document details
6179cd5 chore: remove redundant trans tags

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.$id._index.tsx (+5 -1)

📄 Description

Description

Fixes #2122

Changes Made

Add pluralization

Testing Performed

npm run translate with checking web.po file
npm run build

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Inserted <Trans> into <Plural> component to pass Playwright tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2130 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 11/4/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix(i18n)/2122-add-pluralization` --- ### 📝 Commits (4) - [`0e588ff`](https://github.com/documenso/documenso/commit/0e588fff8aef792af374ad4193e2ba022e39fe4e) fix(i18n): add pluralization to document details - [`976f199`](https://github.com/documenso/documenso/commit/976f199fb71ca0d1519a38f61efd8a8f0d72d30e) chore: re-run tests - [`f132797`](https://github.com/documenso/documenso/commit/f132797985aed2f1b8ba238056b95e306a6d36a0) fix(i18n): add pluralization to document details - [`6179cd5`](https://github.com/documenso/documenso/commit/6179cd5933d71c5268743d85d95b4ce3de40f80c) chore: remove redundant trans tags ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.$id._index.tsx` (+5 -1) </details> ### 📄 Description ## Description Fixes #2122 ## Changes Made   - Add pluralization ## Testing Performed - `npm run translate` with checking web.po file - `npm run build` ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes Inserted `<Trans>` into `<Plural>` component to pass Playwright tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:17 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2066

No description provided.

Rows
Columns