[PR #1930] [MERGED] feat: allow empty placeholder emails on templates #1936

New issue

Closed

opened 2026-02-26 20:31:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1930
Author: @catalinpit
Created: 7/29/2025
Status: ✅ Merged
Merged: 8/12/2025
Merged by: @Mythie

Base: main ← Head: feat/allow-empty-placeholder-emails-templates

📝 Commits (5)

df40ae5 feat: allow empty placeholder emails on templates
1b290ec feat: ui changes to display recipient information
a9cb1a4 feat: more UI changes
988309d feat: update template use dialog
f3cd93d chore: remove the required attribute for the email

📊 Changes

8 files changed (+109 additions, -84 deletions)

View changed files

📝 apps/remix/app/components/dialogs/template-use-dialog.tsx (+6 -1)
📝 apps/remix/app/components/general/template/template-page-view-recipients.tsx (+14 -2)
📝 packages/lib/constants/template.ts (+4 -0)
📝 packages/trpc/server/recipient-router/schema.ts (+18 -3)
📝 packages/ui/components/document/document-read-only-fields.tsx (+14 -3)
📝 packages/ui/primitives/template-flow/add-template-fields.tsx (+29 -15)
📝 packages/ui/primitives/template-flow/add-template-placeholder-recipients.tsx (+7 -57)
📝 packages/ui/primitives/template-flow/add-template-placeholder-recipients.types.ts (+17 -3)

📄 Description

Description

Allow users to create template placeholders without the placeholder emails.

How it works currently:

After the changes:

Video example

https://www.youtube.com/watch?v=v9RKn2lV32U

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1930 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 7/29/2025 **Status:** ✅ Merged **Merged:** 8/12/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/allow-empty-placeholder-emails-templates` --- ### 📝 Commits (5) - [`df40ae5`](https://github.com/documenso/documenso/commit/df40ae529efffe82b011709599209ef013562493) feat: allow empty placeholder emails on templates - [`1b290ec`](https://github.com/documenso/documenso/commit/1b290eca727743efdff97b640816436904ce2d96) feat: ui changes to display recipient information - [`a9cb1a4`](https://github.com/documenso/documenso/commit/a9cb1a47b458e30efa43fb00e59e532fa9f6f8e6) feat: more UI changes - [`988309d`](https://github.com/documenso/documenso/commit/988309df477fc03103e4bcd125ea39edff90f2fb) feat: update template use dialog - [`f3cd93d`](https://github.com/documenso/documenso/commit/f3cd93d308871a1f36e1246ec8c29236b69c6ff6) chore: remove the required attribute for the email ### 📊 Changes **8 files changed** (+109 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/template-use-dialog.tsx` (+6 -1) 📝 `apps/remix/app/components/general/template/template-page-view-recipients.tsx` (+14 -2) 📝 `packages/lib/constants/template.ts` (+4 -0) 📝 `packages/trpc/server/recipient-router/schema.ts` (+18 -3) 📝 `packages/ui/components/document/document-read-only-fields.tsx` (+14 -3) 📝 `packages/ui/primitives/template-flow/add-template-fields.tsx` (+29 -15) 📝 `packages/ui/primitives/template-flow/add-template-placeholder-recipients.tsx` (+7 -57) 📝 `packages/ui/primitives/template-flow/add-template-placeholder-recipients.types.ts` (+17 -3) </details> ### 📄 Description ## Description Allow users to create template placeholders without the placeholder emails. **How it works currently**: <img width="526" height="789" alt="Screenshot 2025-07-29 at 10 28 06" src="https://github.com/user-attachments/assets/fcbe18a1-fa9e-467b-aca0-f216b1c55169" /> **After the changes**: <img width="522" height="794" alt="Screenshot 2025-07-29 at 10 30 29" src="https://github.com/user-attachments/assets/82dc52f6-b74e-4050-a5dc-b141cbeee742" /> ## Video example https://www.youtube.com/watch?v=v9RKn2lV32U ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1936

No description provided.

Rows
Columns