[PR #1919] [MERGED] feat: backport the embedded mobile signing ux to main application #1930

New issue

Closed

opened 2026-02-26 20:31:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1919
Author: @ephraimduncan
Created: 7/23/2025
Status: ✅ Merged
Merged: 8/12/2025
Merged by: @Mythie

Base: main ← Head: feat/signing-mobile-ux

📝 Commits (8)

24dbb3c feat: backport the embedded mobile signing ux to main application
c20f879 fix: position dialog bottom on mobile screen
f1edd2e fix: prevent automatic zoom on mobile phone
02f0aa8 fix: padding on mobile screen
411003f fix: consistent padding
865ba90 Merge branch 'main' into feat/signing-mobile-ux
3a56c4a Merge branch 'main' into feat/signing-mobile-ux
e73f580 fix: revert primitive changes

📊 Changes

3 files changed (+147 additions, -130 deletions)

View changed files

📝 apps/remix/app/components/general/document-signing/document-signing-form.tsx (+64 -107)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view.tsx (+78 -22)
📝 packages/ui/primitives/dialog.tsx (+5 -1)

📄 Description

Description

This PR improves the mobile experience of the document signing page by implementing a collapsible widget design for the signing form. On mobile devices, the form now appears as a fixed bottom sheet that can be expanded/collapsed, while maintaining the sticky sidebar layout on desktop.

Demo

https://github.com/user-attachments/assets/6afe2a4e-eab8-4c5b-b60e-6b569c95f736

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1919 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 8/12/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/signing-mobile-ux` --- ### 📝 Commits (8) - [`24dbb3c`](https://github.com/documenso/documenso/commit/24dbb3cb3c367b99a1603cebca49b7a8f7711554) feat: backport the embedded mobile signing ux to main application - [`c20f879`](https://github.com/documenso/documenso/commit/c20f879e50c24ceb38929e870c20a1f95f425014) fix: position dialog bottom on mobile screen - [`f1edd2e`](https://github.com/documenso/documenso/commit/f1edd2ebbfbbce86bb433754346765ecd127ff41) fix: prevent automatic zoom on mobile phone - [`02f0aa8`](https://github.com/documenso/documenso/commit/02f0aa8ae95bcd99f51125ec0f45595097c49ae6) fix: padding on mobile screen - [`411003f`](https://github.com/documenso/documenso/commit/411003f5644b7075b6ecfa548a27e5ef31caa191) fix: consistent padding - [`865ba90`](https://github.com/documenso/documenso/commit/865ba905128e2775d6b0851f1d089d45d8b3fe86) Merge branch 'main' into feat/signing-mobile-ux - [`3a56c4a`](https://github.com/documenso/documenso/commit/3a56c4a05a03e09d27903c95f37a97c2f6a8d8dd) Merge branch 'main' into feat/signing-mobile-ux - [`e73f580`](https://github.com/documenso/documenso/commit/e73f580e4fc501b78362dc91b7535f89ebc0649b) fix: revert primitive changes ### 📊 Changes **3 files changed** (+147 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/document-signing/document-signing-form.tsx` (+64 -107) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view.tsx` (+78 -22) 📝 `packages/ui/primitives/dialog.tsx` (+5 -1) </details> ### 📄 Description ## Description This PR improves the mobile experience of the document signing page by implementing a collapsible widget design for the signing form. On mobile devices, the form now appears as a fixed bottom sheet that can be expanded/collapsed, while maintaining the sticky sidebar layout on desktop. ## Demo https://github.com/user-attachments/assets/6afe2a4e-eab8-4c5b-b60e-6b569c95f736 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:42 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:44 +03:00

[PR #1930] [MERGED] feat: allow empty placeholder emails on templates #1936

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1930

No description provided.

Rows
Columns