starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1828] [CLOSED] feat: Allow team member selection in signing flow #1874

New issue

Closed

opened 2026-02-26 20:31:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1828
Author: @chbiel
Created: 6/6/2025
Status: ❌ Closed

Base: main ← Head: feat/allow_team_member_selection_in_signing_flow

📝 Commits (3)

7d28d59 feat: allow selection of team members when adding document signers
5a94fa0 feat: add translations
15b2006 Merge branch 'main' into feat/allow_team_member_selection_in_signing_flow

📊 Changes

10 files changed (+637 additions, -1 deletions)

View changed files

📝 .gitignore (+1 -0)
➕ apps/remix/app/components/dialogs/team-member-select-dialog.tsx (+110 -0)
📝 packages/app-tests/e2e/document-flow/signers-step.spec.ts (+42 -1)
📝 packages/lib/translations/de/web.po (+75 -0)
📝 packages/lib/translations/en/web.po (+75 -0)
📝 packages/lib/translations/es/web.po (+75 -0)
📝 packages/lib/translations/fr/web.po (+75 -0)
📝 packages/lib/translations/it/web.po (+75 -0)
📝 packages/lib/translations/pl/web.po (+75 -0)
📝 packages/ui/primitives/document-flow/add-signers.tsx (+34 -0)

📄 Description

name: Pull Request
about: Submit changes to the project for review and inclusion

Description

I found it strange that, although I had my team members invited, I had to type their email addresses and names.

So I added a new button next to "Add signer" that opens a dialog to select available team member and add them as signers.

Guidance needed

I need some guidance on:

There have been many translations added that are unrelated to my change. Should I remove them or keep?
Did I follow your code guidelines well enough?
Are further changes needed?

Changes Made

Added a new dialog that uses the multiselect combobox
Add a button to the add signers step
Change z-index of combobox menu to be usable inside dialogs
Added playwright test
Added translations

Testing Performed

nothing special beside the playwright test and obvious manual testing

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines. (I hope...)
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1828 **Author:** [@chbiel](https://github.com/chbiel) **Created:** 6/6/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/allow_team_member_selection_in_signing_flow` --- ### 📝 Commits (3) - [`7d28d59`](https://github.com/documenso/documenso/commit/7d28d5956f5f5cf141f37b00c1bd343af29bf0a7) feat: allow selection of team members when adding document signers - [`5a94fa0`](https://github.com/documenso/documenso/commit/5a94fa0b67cb23e3ae50844c826cab138978a92c) feat: add translations - [`15b2006`](https://github.com/documenso/documenso/commit/15b2006ea6b0ba9bd449b1a95338aedc96a2e264) Merge branch 'main' into feat/allow_team_member_selection_in_signing_flow ### 📊 Changes **10 files changed** (+637 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `apps/remix/app/components/dialogs/team-member-select-dialog.tsx` (+110 -0) 📝 `packages/app-tests/e2e/document-flow/signers-step.spec.ts` (+42 -1) 📝 `packages/lib/translations/de/web.po` (+75 -0) 📝 `packages/lib/translations/en/web.po` (+75 -0) 📝 `packages/lib/translations/es/web.po` (+75 -0) 📝 `packages/lib/translations/fr/web.po` (+75 -0) 📝 `packages/lib/translations/it/web.po` (+75 -0) 📝 `packages/lib/translations/pl/web.po` (+75 -0) 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+34 -0) </details> ### 📄 Description --- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description I found it strange that, although I had my team members invited, I had to type their email addresses and names. So I added a new button next to "Add signer" that opens a dialog to select available team member and add them as signers. ![image](https://github.com/user-attachments/assets/1ab3aa0f-6a26-4d96-ab35-bb2157b0d6a9) ![image](https://github.com/user-attachments/assets/73b16b23-5615-4165-91ae-e95748015d3d) ![image](https://github.com/user-attachments/assets/5c84a596-dc4a-46cc-bb50-b3aa3decc7a5) ![image](https://github.com/user-attachments/assets/b0802be2-bde5-4328-8854-9600269c1eca) ## Guidance needed I need some guidance on: - There have been many translations added that are unrelated to my change. Should I remove them or keep? - Did I follow your code guidelines well enough? - Are further changes needed? ## Changes Made - Added a new dialog that uses the multiselect combobox - Add a button to the add signers step - Change z-index of combobox menu to be usable inside dialogs - Added playwright test - Added translations ## Testing Performed nothing special beside the playwright test and obvious manual testing ## Checklist - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. (I hope...) - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1874

No description provided.

Rows
Columns