starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1752] [MERGED] fix: optional fields being required in direct links #1828

New issue

Closed

opened 2026-02-26 20:31:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1752
Author: @catalinpit
Created: 4/17/2025
Status: ✅ Merged
Merged: 4/21/2025
Merged by: @Mythie

Base: main ← Head: fix/optional-fields-direct-link

📝 Commits (10+)

9fb98a5 fix: optional fields being required in direct links
7a87759 fix: return structured signedValue in DirectTemplatePageView
cb5a2dc fix: remove console logs and fix signedFieldValues type
e66bac4 Merge branch 'main' into fix/optional-fields-direct-link
0b9982f Merge branch 'main' into fix/optional-fields-direct-link
f28dd5f Merge branch 'main' into fix/optional-fields-direct-link
0cb17a7 Merge branch 'main' into fix/optional-fields-direct-link
4e0d337 Merge branch 'main' into fix/optional-fields-direct-link
4dd0604 Merge branch 'main' into fix/optional-fields-direct-link
b46d436 Merge branch 'main' into fix/optional-fields-direct-link

📊 Changes

2 files changed (+17 additions, -5 deletions)

View changed files

📝 apps/remix/app/components/general/direct-template/direct-template-page.tsx (+9 -2)
📝 apps/remix/app/components/general/direct-template/direct-template-signing-form.tsx (+8 -3)

📄 Description

name: Pull Request
about: Submit changes to the project for review and inclusion

Description

Changes Made

Change 1
Change 2
...

Testing Performed

Tested feature X in scenario Y.
Ran unit tests for component Z.
Tested on browsers A, B, and C.
...

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1752 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 4/17/2025 **Status:** ✅ Merged **Merged:** 4/21/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/optional-fields-direct-link` --- ### 📝 Commits (10+) - [`9fb98a5`](https://github.com/documenso/documenso/commit/9fb98a56cef58fd4441fe293868c6c05042b4384) fix: optional fields being required in direct links - [`7a87759`](https://github.com/documenso/documenso/commit/7a87759ef68df8ef978aceea3c446a60518a00b1) fix: return structured signedValue in DirectTemplatePageView - [`cb5a2dc`](https://github.com/documenso/documenso/commit/cb5a2dc4d779ea0933bdad731b05be83cc5523f6) fix: remove console logs and fix signedFieldValues type - [`e66bac4`](https://github.com/documenso/documenso/commit/e66bac4b9a40e7f3fb0ba88c474292f6d6d152b7) Merge branch 'main' into fix/optional-fields-direct-link - [`0b9982f`](https://github.com/documenso/documenso/commit/0b9982f65a3775c9df4d07204e1071c99bd349ee) Merge branch 'main' into fix/optional-fields-direct-link - [`f28dd5f`](https://github.com/documenso/documenso/commit/f28dd5f216a31467d8dc4efb09f60780d804918d) Merge branch 'main' into fix/optional-fields-direct-link - [`0cb17a7`](https://github.com/documenso/documenso/commit/0cb17a7f186d0f3ba426866143ba6aea30449284) Merge branch 'main' into fix/optional-fields-direct-link - [`4e0d337`](https://github.com/documenso/documenso/commit/4e0d33744bbb890c266024d7865b46758ff6dd01) Merge branch 'main' into fix/optional-fields-direct-link - [`4dd0604`](https://github.com/documenso/documenso/commit/4dd060404e49ec6c190b8266bebbc188a40a969f) Merge branch 'main' into fix/optional-fields-direct-link - [`b46d436`](https://github.com/documenso/documenso/commit/b46d4368e1ff2593898f71f616c8964fafd8619f) Merge branch 'main' into fix/optional-fields-direct-link ### 📊 Changes **2 files changed** (+17 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/direct-template/direct-template-page.tsx` (+9 -2) 📝 `apps/remix/app/components/general/direct-template/direct-template-signing-form.tsx` (+8 -3) </details> ### 📄 Description --- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description   ## Related Issue   ## Changes Made   - Change 1 - Change 2 - ... ## Testing Performed   - Tested feature X in scenario Y. - Ran unit tests for component Z. - Tested on browsers A, B, and C. - ... ## Checklist   - [ ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:14 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:28 +03:00

[PR #1828] [CLOSED] feat: Allow team member selection in signing flow #1874

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1828

No description provided.

Rows
Columns