starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1677] [MERGED] fix: stripe price fetch #1786

New issue

Closed

opened 2026-02-26 20:31:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1677
Author: @dguyen
Created: 2/27/2025
Status: ✅ Merged
Merged: 2/27/2025
Merged by: @Mythie

Base: main ← Head: fix/stripe-price-fetch

📝 Commits (1)

8815444 fix: stripe price fetch

📊 Changes

1 file changed (+5 additions, -6 deletions)

View changed files

📝 packages/ee/server-only/stripe/get-prices-by-plan.ts (+5 -6)

📄 Description

Description

Currently Stripe prices search is omitting a price for an unknown reason.

Changed our fetch logic to use list instead of search allows us to work around the issue.

It's unknown on the performance impact of using list vs search

Testing

Ran old and new fetches
Diffed results
New result showed the missing price

Simplified testing:

const oldResult = await oldGetPricesByPlan(['regular', 'community', 'platform', 'enterprise']);
const newResult = await newGetPricesByPlan(['regular', 'community', 'platform', 'enterprise']);

console.log({
  oldResultPriceLength: oldResult.length, // 13
  newResultPriceLength: newResult.length, // 14
});

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1677 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 2/27/2025 **Status:** ✅ Merged **Merged:** 2/27/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/stripe-price-fetch` --- ### 📝 Commits (1) - [`8815444`](https://github.com/documenso/documenso/commit/88154440c7c665872d9f35d470b025bd3cd948af) fix: stripe price fetch ### 📊 Changes **1 file changed** (+5 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/ee/server-only/stripe/get-prices-by-plan.ts` (+5 -6) </details> ### 📄 Description ## Description Currently Stripe prices search is omitting a price for an unknown reason. Changed our fetch logic to use `list` instead of `search` allows us to work around the issue. It's unknown on the performance impact of using `list` vs `search` ## Testing 1. Ran old and new fetches 2. Diffed results 3. New result showed the missing price Simplified testing: ```typescript const oldResult = await oldGetPricesByPlan(['regular', 'community', 'platform', 'enterprise']); const newResult = await newGetPricesByPlan(['regular', 'community', 'platform', 'enterprise']); console.log({ oldResultPriceLength: oldResult.length, // 13 newResultPriceLength: newResult.length, // 14 }); ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:04 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:19 +03:00

[PR #1786] [CLOSED] Test chat #1845

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1786

No description provided.

Rows
Columns