[PR #1506] [MERGED] fix: dateformat api bug #1677

New issue

Closed

opened 2026-02-26 19:34:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1506
Author: @catalinpit
Created: 12/4/2024
Status: ✅ Merged
Merged: 12/4/2024
Merged by: @dguyen

Base: main ← Head: fix/dateformat-api-bug-part2

📝 Commits (2)

85b0b48 fix: dateformat api bug
c2de52a Merge branch 'main' into fix/dateformat-api-bug-part2

📊 Changes

1 file changed (+8 additions, -10 deletions)

View changed files

📝 packages/api/v1/implementation.ts (+8 -10)

📄 Description

There was an error in comparing the dateFormat passed by the user with the label property of the date objects from the DATE_FORMATS array. It should compare it with the value property.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1506 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 12/4/2024 **Status:** ✅ Merged **Merged:** 12/4/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/dateformat-api-bug-part2` --- ### 📝 Commits (2) - [`85b0b48`](https://github.com/documenso/documenso/commit/85b0b487397d09013ab7587b55bb8f032de25b65) fix: dateformat api bug - [`c2de52a`](https://github.com/documenso/documenso/commit/c2de52a3d5ccf00a71f46cf08e3881ac7efccefa) Merge branch 'main' into fix/dateformat-api-bug-part2 ### 📊 Changes **1 file changed** (+8 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/v1/implementation.ts` (+8 -10) </details> ### 📄 Description There was an error in comparing the `dateFormat` passed by the user with the `label` property of the date objects from the `DATE_FORMATS` array. It should compare it with the `value` property. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:17 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:04 +03:00

[PR #1677] [MERGED] fix: stripe price fetch #1786

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1677

No description provided.

Rows
Columns