[PR #1658] [CLOSED] feat: Add support for disabling sending emails #1774

Closed
opened 2026-02-26 20:31:00 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1658
Author: @dnimon
Created: 2/19/2025
Status: Closed

Base: archive/nextjsHead: disable-email


📝 Commits (1)

  • cfd9de1 feature: Add support for disabling sending emails

📊 Changes

4 files changed (+27 additions, -2 deletions)

View changed files

📝 .env.example (+1 -1)
📝 packages/email/mailer.ts (+8 -0)
packages/email/transports/disabled.ts (+17 -0)
📝 packages/tsconfig/process-env.d.ts (+1 -1)

📄 Description


name: Pull Request
about: Submit changes to the project for review and inclusion

Description

This adds the ability to disable sending emails altogether. This can be useful for cases where you're wanting to use the API and embed directly, and take care of your own notifications.

Please let me know of any changes needed here.

N/A

Changes Made

  • Added an additional "disabled" option to the NEXT_PRIVATE_SMTP_TRANSPORT variable
  • Created a disabled transport, which mainly is a stub around the sendmail which does nothing

Testing Performed

Was able to verify with a docker build that no emails are being sent. Without this change, I did not have any email settings, and was getting errors when trying to sign a document.

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1658 **Author:** [@dnimon](https://github.com/dnimon) **Created:** 2/19/2025 **Status:** ❌ Closed **Base:** `archive/nextjs` ← **Head:** `disable-email` --- ### 📝 Commits (1) - [`cfd9de1`](https://github.com/documenso/documenso/commit/cfd9de1ca3749bf35efd49f000e0412173279ce4) feature: Add support for disabling sending emails ### 📊 Changes **4 files changed** (+27 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+1 -1) 📝 `packages/email/mailer.ts` (+8 -0) ➕ `packages/email/transports/disabled.ts` (+17 -0) 📝 `packages/tsconfig/process-env.d.ts` (+1 -1) </details> ### 📄 Description --- name: Pull Request about: Submit changes to the project for review and inclusion --- ## Description This adds the ability to disable sending emails altogether. This can be useful for cases where you're wanting to use the API and embed directly, and take care of your own notifications. Please let me know of any changes needed here. ## Related Issue N/A ## Changes Made * Added an additional "disabled" option to the NEXT_PRIVATE_SMTP_TRANSPORT variable * Created a disabled transport, which mainly is a stub around the sendmail which does nothing ## Testing Performed Was able to verify with a docker build that no emails are being sent. Without this change, I did not have any email settings, and was getting errors when trying to sign a document. ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [X] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [X] I have updated the documentation to reflect these changes, if applicable. - [X] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes <!--- Provide any additional context or notes for the reviewers. --> <!--- This might include details about design decisions, potential concerns, or anything else relevant. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:31:00 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1774
No description provided.