starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #1477] [MERGED] feat: download doc without signing certificate #1658

New issue

Closed

opened 2026-02-26 19:34:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1477
Author: @catalinpit
Created: 11/15/2024
Status: ✅ Merged
Merged: 11/25/2024
Merged by: @Mythie

Base: main ← Head: feat/download-document-without-certificate

📝 Commits (9)

0f79e32 feat: download doc without signing certificate
dd95f79 Merge branch 'main' into feat/download-document-without-certificate
a0a8947 Merge branch 'main' into feat/download-document-without-certificate
74353bf Merge branch 'main' into feat/download-document-without-certificate
6985846 chore: add signing certificate as a team preference
119b060 chore: fix cert generation logic
e129e5a chore: update ternary and add language support
d7ff1cf chore: add tests
3ee6a1a chore: update logic for cert lang

📊 Changes

22 files changed (+624 additions, -201 deletions)

View changed files

📝 apps/web/src/app/(teams)/t/[teamUrl]/settings/preferences/document-preferences.tsx (+40 -1)
📝 package-lock.json (+3 -1)
➕ packages/app-tests/e2e/features/include-document-certificate.spec.ts (+271 -0)
📝 packages/app-tests/package.json (+4 -2)
📝 packages/lib/jobs/definitions/emails/send-team-deleted-email.ts (+1 -0)
📝 packages/lib/jobs/definitions/internal/seal-document.ts (+17 -1)
📝 packages/lib/server-only/document/seal-document.ts (+19 -7)
📝 packages/lib/server-only/htmltopdf/get-certificate-pdf.ts (+12 -11)
📝 packages/lib/server-only/team/update-team-document-settings.ts (+5 -1)
📝 packages/lib/translations/de/common.po (+0 -1)
📝 packages/lib/translations/de/marketing.po (+0 -1)
📝 packages/lib/translations/de/web.po (+61 -42)
📝 packages/lib/translations/en/web.po (+61 -41)
📝 packages/lib/translations/es/common.po (+0 -1)
📝 packages/lib/translations/es/marketing.po (+0 -1)
📝 packages/lib/translations/es/web.po (+61 -42)
📝 packages/lib/translations/fr/common.po (+0 -1)
📝 packages/lib/translations/fr/marketing.po (+0 -1)
📝 packages/lib/translations/fr/web.po (+61 -42)
➕ packages/prisma/migrations/20241122081012_download_document_without_certificate/migration.sql (+2 -0)

...and 2 more files

📄 Description

Description

I added the option of downloading a document without the signing certificate for teams. They can disable/enable the option in the preferences tab.

The signing certificate can still be downloaded separately from the logs page.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Summary by CodeRabbit

New Features
- Introduced a new option to include a signing certificate in document preferences, enhancing user control over document settings.
- Added a toggle for the signing certificate in the document preferences form.
Bug Fixes
- Improved logic for document sealing to conditionally include signing certificates based on team settings.
Translations
- Updated translations for German, Spanish, and French to include new entries and improve existing phrases related to document actions and settings.
- Added new translation for "Include the Signing Certificate in the Document" across multiple languages.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1477 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 11/15/2024 **Status:** ✅ Merged **Merged:** 11/25/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/download-document-without-certificate` --- ### 📝 Commits (9) - [`0f79e32`](https://github.com/documenso/documenso/commit/0f79e32b3eb0550344b5ed6497dc556e1b42bc29) feat: download doc without signing certificate - [`dd95f79`](https://github.com/documenso/documenso/commit/dd95f7930c1f7fa7c96063737a9462d83f648dd9) Merge branch 'main' into feat/download-document-without-certificate - [`a0a8947`](https://github.com/documenso/documenso/commit/a0a89478a4e5d3add4cb70f8840c6a1d42efe3c9) Merge branch 'main' into feat/download-document-without-certificate - [`74353bf`](https://github.com/documenso/documenso/commit/74353bf15496ae49c498e5b9b46fc6a2679cf7a2) Merge branch 'main' into feat/download-document-without-certificate - [`6985846`](https://github.com/documenso/documenso/commit/69858467b997564b6b4c41d52bd797a7e5ee93be) chore: add signing certificate as a team preference - [`119b060`](https://github.com/documenso/documenso/commit/119b060e3f03e0880d6e90a3a8359aeb18f15800) chore: fix cert generation logic - [`e129e5a`](https://github.com/documenso/documenso/commit/e129e5abd9014c0915425c6c3c2dd2a6a15a6706) chore: update ternary and add language support - [`d7ff1cf`](https://github.com/documenso/documenso/commit/d7ff1cf62ce31ec450da91e87359593028d8f872) chore: add tests - [`3ee6a1a`](https://github.com/documenso/documenso/commit/3ee6a1a1efc9c71b1668ff14d091b8a8be2941ef) chore: update logic for cert lang ### 📊 Changes **22 files changed** (+624 additions, -201 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(teams)/t/[teamUrl]/settings/preferences/document-preferences.tsx` (+40 -1) 📝 `package-lock.json` (+3 -1) ➕ `packages/app-tests/e2e/features/include-document-certificate.spec.ts` (+271 -0) 📝 `packages/app-tests/package.json` (+4 -2) 📝 `packages/lib/jobs/definitions/emails/send-team-deleted-email.ts` (+1 -0) 📝 `packages/lib/jobs/definitions/internal/seal-document.ts` (+17 -1) 📝 `packages/lib/server-only/document/seal-document.ts` (+19 -7) 📝 `packages/lib/server-only/htmltopdf/get-certificate-pdf.ts` (+12 -11) 📝 `packages/lib/server-only/team/update-team-document-settings.ts` (+5 -1) 📝 `packages/lib/translations/de/common.po` (+0 -1) 📝 `packages/lib/translations/de/marketing.po` (+0 -1) 📝 `packages/lib/translations/de/web.po` (+61 -42) 📝 `packages/lib/translations/en/web.po` (+61 -41) 📝 `packages/lib/translations/es/common.po` (+0 -1) 📝 `packages/lib/translations/es/marketing.po` (+0 -1) 📝 `packages/lib/translations/es/web.po` (+61 -42) 📝 `packages/lib/translations/fr/common.po` (+0 -1) 📝 `packages/lib/translations/fr/marketing.po` (+0 -1) 📝 `packages/lib/translations/fr/web.po` (+61 -42) ➕ `packages/prisma/migrations/20241122081012_download_document_without_certificate/migration.sql` (+2 -0) _...and 2 more files_ </details> ### 📄 Description ## Description I added the option of downloading a document without the signing certificate for teams. They can disable/enable the option in the preferences tab. The signing certificate can still be downloaded separately from the `logs` page. ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable.  ## Summary by CodeRabbit - **New Features** - Introduced a new option to include a signing certificate in document preferences, enhancing user control over document settings. - Added a toggle for the signing certificate in the document preferences form. - **Bug Fixes** - Improved logic for document sealing to conditionally include signing certificates based on team settings. - **Translations** - Updated translations for German, Spanish, and French to include new entries and improve existing phrases related to document actions and settings. - Added new translation for "Include the Signing Certificate in the Document" across multiple languages.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:12 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:00 +03:00

[PR #1658] [CLOSED] feat: Add support for disabling sending emails #1774

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1658

No description provided.

Rows
Columns