[GH-ISSUE #621] [IMPROVEMENT]: more specific instructions for adding a document

kerem commented

2026-02-26 18:45:41 +03:00

Owner

Originally created by @Dun-sin on GitHub (Nov 2, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/621

Originally assigned to: @sumitbishti on GitHub.

Improvement Description

I think the following should be added:

the type of file which can be uploaded
the limit of the file to be uploaded

Rationale

I tried using the app for the first time and the first time and immediately thought to upload msword to check as it ended with .doc extension, so specifying what file format/extension would be accepted.

Adding the limit it has would also help with users avoiding the large file and know beforehand what is required.

Proposed Solution

No response

Alternatives (optional)

No response

Additional Context

No response

Please check the boxes that apply to this improvement suggestion.

I have searched the existing issues and improvement suggestions to avoid duplication.
I have provided a clear description of the improvement being suggested.
I have explained the rationale behind this improvement.
I have included any relevant technical details or design suggestions.
I understand that this is a suggestion and that there is no guarantee of implementation.

Originally created by @Dun-sin on GitHub (Nov 2, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/621 Originally assigned to: @sumitbishti on GitHub. ### Improvement Description I think the following should be added: - the type of file which can be uploaded - the limit of the file to be uploaded ![image](https://github.com/documenso/documenso/assets/78784850/48fe0107-905c-4be0-b0a5-c676f2bc995b) ### Rationale I tried using the app for the first time and the first time and immediately thought to upload msword to check as it ended with .doc extension, so specifying what file format/extension would be accepted. Adding the limit it has would also help with users avoiding the large file and know beforehand what is required. ### Proposed Solution _No response_ ### Alternatives (optional) _No response_ ### Additional Context _No response_ ### Please check the boxes that apply to this improvement suggestion. - [X] I have searched the existing issues and improvement suggestions to avoid duplication. - [X] I have provided a clear description of the improvement being suggested. - [X] I have explained the rationale behind this improvement. - [X] I have included any relevant technical details or design suggestions. - [X] I understand that this is a suggestion and that there is no guarantee of implementation.

kerem

2026-02-26 18:45:41 +03:00

closed this issue
added the
type: enhancement

status: assigned

apps: web

community
labels

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@Dun-sin commented on GitHub (Nov 2, 2023):

i would like to work on this if this is a accepted change and any way you want me to do that.

@Dun-sin commented on GitHub (Nov 2, 2023): i would like to work on this if this is a accepted change and any way you want me to do that.

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@catalinpit commented on GitHub (Nov 6, 2023):

Hey @Dun-sin, thanks for the suggestions! I agree that adding the maximum document limit would be helpful. Regarding the doc type, do people usually sign non-pdfs?

@catalinpit commented on GitHub (Nov 6, 2023): Hey @Dun-sin, thanks for the suggestions! I agree that adding the maximum document limit would be helpful. Regarding the doc type, do people usually sign non-pdfs?

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@Dun-sin commented on GitHub (Nov 6, 2023):

Hey @Dun-sin, thanks for the suggestions! I agree that adding the maximum document limit would be helpful. Regarding the doc type, do people usually sign non-pdfs?

no, they don't i know that, but when you go to image converter site for instance, they still indicate to upload an image, i mean we both know users are a mystery, it can be skipped btw doesn't really matter, the most important in my opinion is the file limit

@Dun-sin commented on GitHub (Nov 6, 2023): > Hey @Dun-sin, thanks for the suggestions! I agree that adding the maximum document limit would be helpful. Regarding the doc type, do people usually sign non-pdfs? no, they don't i know that, but when you go to image converter site for instance, they still indicate to upload an image, i mean we both know users are a mystery, it can be skipped btw doesn't really matter, the most important in my opinion is the file limit

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Dec 8, 2023):

This issue has not seen activity for a while. It will be closed in 30 days unless further activity is detected

@github-actions[bot] commented on GitHub (Dec 8, 2023): This issue has not seen activity for a while. It will be closed in 30 days unless further activity is detected

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@sumitbishti commented on GitHub (Jan 13, 2024):

is anyone working on this issue?

@sumitbishti commented on GitHub (Jan 13, 2024): is anyone working on this issue?

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@dguyen commented on GitHub (Jan 23, 2024):

Apologies to those involved for the delay, this one seemed to have gotten lost.

@Dun-sin are you still interested in working on this feature? If not I can assign it to @sumitbishti

To summarise some things:

I tried using the app for the first time and the first time and immediately thought to upload msword to check as it ended with .doc extension, so specifying what file format/extension would be accepted.

I think changing the text to Drag & drop your PDF document here. should suffice.

Adding the limit it has would also help with users avoiding the large file and know beforehand what is required.

Agreed, I believe that the current upload limit is 50MBs for the S3 upload transport we implemented. Currently if you select a file that exceeds the limit, it will silently error.

Since users would rarely upload a 50mb document, we can keep the UI clean by displaying a toast when they select a file that's too large. The toast should contain the information on the current current file size limit.

This would involve displaying a toast error saying the current file limit size when a file limit size error occurs via onDropRejected in useDropzone.

@dguyen commented on GitHub (Jan 23, 2024): Apologies to those involved for the delay, this one seemed to have gotten lost. @Dun-sin are you still interested in working on this feature? If not I can assign it to @sumitbishti To summarise some things: > I tried using the app for the first time and the first time and immediately thought to upload msword to check as it ended with .doc extension, so specifying what file format/extension would be accepted. I think changing the text to `Drag & drop your PDF document here.` should suffice. > Adding the limit it has would also help with users avoiding the large file and know beforehand what is required. Agreed, I believe that the current upload limit is 50MBs for the S3 upload transport we implemented. Currently if you select a file that exceeds the limit, it will silently error. Since users would rarely upload a 50mb document, we can keep the UI clean by displaying a toast when they select a file that's too large. The toast should contain the information on the current current file size limit. This would involve displaying a toast error saying the current file limit size when a file limit size error occurs via `onDropRejected` in `useDropzone`.

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@sumitbishti commented on GitHub (Jan 23, 2024):

Would be happy to work on this.

@sumitbishti commented on GitHub (Jan 23, 2024): Would be happy to work on this.

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@Dun-sin commented on GitHub (Jan 23, 2024):

Apologies to those involved for the delay, this one seemed to have gotten lost.

@Dun-sin are you still interested in working on this feature? If not I can assign it to @sumitbishti

To summarise some things:

I tried using the app for the first time and the first time and immediately thought to upload msword to check as it ended with .doc extension, so specifying what file format/extension would be accepted.

I think changing the text to Drag & drop your PDF document here. should suffice.

Adding the limit it has would also help with users avoiding the large file and know beforehand what is required.

Agreed, I believe that the current upload limit is 50MBs for the S3 upload transport we implemented. Currently if you select a file that exceeds the limit, it will silently error.

Since users would rarely upload a 50mb document, we can keep the UI clean by displaying a toast when they select a file that's too large. The toast should contain the information on the current current file size limit.

This would involve displaying a toast error saying the current file limit size when a file limit size error occurs via onDropRejected in useDropzone.

you can give it to @sumitbishti

@Dun-sin commented on GitHub (Jan 23, 2024): > Apologies to those involved for the delay, this one seemed to have gotten lost. > > @Dun-sin are you still interested in working on this feature? If not I can assign it to @sumitbishti > > To summarise some things: > > > I tried using the app for the first time and the first time and immediately thought to upload msword to check as it ended with .doc extension, so specifying what file format/extension would be accepted. > > I think changing the text to `Drag & drop your PDF document here.` should suffice. > > > Adding the limit it has would also help with users avoiding the large file and know beforehand what is required. > > Agreed, I believe that the current upload limit is 50MBs for the S3 upload transport we implemented. Currently if you select a file that exceeds the limit, it will silently error. > > Since users would rarely upload a 50mb document, we can keep the UI clean by displaying a toast when they select a file that's too large. The toast should contain the information on the current current file size limit. > > This would involve displaying a toast error saying the current file limit size when a file limit size error occurs via `onDropRejected` in `useDropzone`. you can give it to @sumitbishti

kerem commented

2026-02-26 18:45:42 +03:00

Author

Owner

@dguyen commented on GitHub (Jan 24, 2024):

@sumitbishti I've assigned it to you :)

@dguyen commented on GitHub (Jan 24, 2024): @sumitbishti I've assigned it to you :)

kerem referenced this issue

2026-02-26 18:48:51 +03:00

[PR #171] [MERGED] Add turborepo to monorepo. #771

Rows
Columns

[GH-ISSUE #621] [IMPROVEMENT]: more specific instructions for adding a document #171

Improvement Description

Rationale

Proposed Solution

Alternatives (optional)

Additional Context

Please check the boxes that apply to this improvement suggestion.