starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[GH-ISSUE #2134] i18n: No distinction in group deletion messages #621

New issue

Closed

opened 2026-02-26 18:47:48 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 18:47:48 +03:00

Owner

Originally created by @mKoonrad on GitHub (Nov 5, 2025).
Original GitHub issue: https://github.com/documenso/documenso/issues/2134

Issue Description

Look at these strings in 2 different components for deleting group:
github.com/documenso/documenso@d2a009d52e/apps/remix/app/components/dialogs/team-group-delete-dialog.tsx (L84-L87)
github.com/documenso/documenso@d2a009d52e/apps/remix/app/components/dialogs/organisation-group-delete-dialog.tsx (L80-L83)
Translation tool merge these strings into a single entry for translation.
github.com/documenso/documenso@d2a009d52e/packages/lib/translations/en/web.po (L10281-L10286)
This removes context for each message of whether the user is deleting a group from an organisation or a team.

This is problematic for languages with grammatical gender and cases (like Polish, German, French, etc.). In these languages, the translation may need to be different based on the context. For example:

"from the organisation" (feminine gender)
"from the team" (masculine gender)

This linguistic difference cannot be expressed if both strings are merged into one.

Steps to Reproduce

OrganisationGroupDeleteDialog.tsx uses text: You are about to remove the following group from {organisation.name}.
TeamGroupDeleteDialog.tsx uses identical text: You are about to remove the following group from {team.name}.

This creates a single, shared translation entry (msgid), removing the context of whether it's a team or organisation.

Expected Behavior

Source strings should be slightly different by special comment (<Trans comment="any context") or different text. I suggest 2 different source strings:

<Trans>You are about to remove the following group from team {team.name}.</Trans>
<Trans>You are about to remove the following group from organization {organisation.name}.</Trans>

Current Behavior

Both components use identical <Trans> block.

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome

Version [e.g., 2.0.1]

v1.13.1

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @mKoonrad on GitHub (Nov 5, 2025). Original GitHub issue: https://github.com/documenso/documenso/issues/2134 ### Issue Description Look at these strings in 2 different components for deleting group: https://github.com/documenso/documenso/blob/d2a009d52e2ff81f984f9ab0e348f8f5c7c7a17a/apps/remix/app/components/dialogs/team-group-delete-dialog.tsx#L84-L87 https://github.com/documenso/documenso/blob/d2a009d52e2ff81f984f9ab0e348f8f5c7c7a17a/apps/remix/app/components/dialogs/organisation-group-delete-dialog.tsx#L80-L83 Translation tool merge these strings into a single entry for translation. https://github.com/documenso/documenso/blob/d2a009d52e2ff81f984f9ab0e348f8f5c7c7a17a/packages/lib/translations/en/web.po#L10281-L10286 This removes context for each message of whether the user is deleting a group from an organisation or a team. This is problematic for languages with grammatical gender and cases (like Polish, German, French, etc.). In these languages, the translation may need to be different based on the context. For example: - "from the organisation" (feminine gender) - "from the team" (masculine gender) This linguistic difference cannot be expressed if both strings are merged into one. ### Steps to Reproduce - `OrganisationGroupDeleteDialog.tsx` uses text: `You are about to remove the following group from {organisation.name}`. - `TeamGroupDeleteDialog.tsx` uses identical text: `You are about to remove the following group from {team.name}`. This creates a single, shared translation entry (msgid), removing the context of whether it's a team or organisation. ### Expected Behavior Source strings should be slightly different by special comment (`<Trans comment="any context"`) or different text. I suggest 2 different source strings: 1. `<Trans>You are about to remove the following group from team {team.name}.</Trans>` 2. `<Trans>You are about to remove the following group from organization {organisation.name}.</Trans>` ### Current Behavior Both components use identical `<Trans>` block. ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] Windows 11 ### Browser [e.g., Chrome, Firefox] Chrome ### Version [e.g., 2.0.1] v1.13.1 ### Please check the boxes that apply to this issue report. - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [ ] I have included any relevant screenshots. - [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [x] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:47:48 +03:00

closed this issue
added the
Stale

status: triage
labels

kerem commented

2026-02-26 18:47:49 +03:00

Author

Owner

@coderabbitai[bot] commented on GitHub (Nov 5, 2025):

A summary of the changes CodeRabbit can apply:

Add context-specific source strings and Lingui comment attributes by updating TeamGroupDeleteDialog.tsx and OrganisationGroupDeleteDialog.tsx (injecting "team"/"organization" into the English text and adding a ) to produce separate translation entries for team vs organization group deletion, then regenerate translations with npm run lingui:extract.

Update two delete-dialog components to modify the displayed sentence and i18n metadata: replace the ambiguous "from{' '}" fragment with explicit "from organization" (apps/remix/app/components/dialogs/organisation-group-delete-dialog.tsx) and "from team" (apps/remix/app/components/dialogs/team-group-delete-dialog.tsx), and add corresponding attributes ("Deleting group from organisation context" and "Deleting group from team context") for translation context.

✅ Create PR with these edits
📋 Get copyable edits

@coderabbitai[bot] commented on GitHub (Nov 5, 2025):  A summary of the changes CodeRabbit can apply: > - Add context-specific source strings and Lingui comment attributes by updating TeamGroupDeleteDialog.tsx and OrganisationGroupDeleteDialog.tsx (injecting "team"/"organization" into the English text and adding a <Trans comment="…">) to produce separate translation entries for team vs organization group deletion, then regenerate translations with `npm run lingui:extract`. > > - Update two delete-dialog components to modify the displayed sentence and i18n metadata: replace the ambiguous "from{' '}" fragment with explicit "from organization" (apps/remix/app/components/dialogs/organisation-group-delete-dialog.tsx) and "from team" (apps/remix/app/components/dialogs/team-group-delete-dialog.tsx), and add corresponding <Trans comment="..."> attributes ("Deleting group from organisation context" and "Deleting group from team context") for translation context. - [ ]  ✅ Create PR with these edits - [ ]  📋 Get copyable edits

kerem commented

2026-02-26 18:47:49 +03:00

Author

Owner

@mKoonrad commented on GitHub (Feb 10, 2026):

Resolved in #2452

@mKoonrad commented on GitHub (Feb 10, 2026): Resolved in #2452

kerem referenced this issue

2026-02-26 19:32:20 +03:00

[PR #867] [MERGED] perf: mentioned type and size of the doc to be uploaded #1218

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#621

No description provided.

Rows
Columns