starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1534] [MERGED] feat: add controls for sending completion emails to document owners #1698

New issue

Closed

opened 2026-02-26 20:30:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:30:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1534
Author: @Mythie
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/12/2024
Merged by: @Mythie

Base: main ← Head: feat/add-owner-completed-email-setting

📝 Commits (1)

efd6531 feat: add controls for sending completion emails to document owners

📊 Changes

6 files changed (+241 additions, -66 deletions)

View changed files

📝 packages/api/v1/implementation.ts (+41 -57)
📝 packages/api/v1/schema.ts (+5 -1)
➕ packages/app-tests/e2e/api/v1/document-sending.spec.ts (+137 -0)
📝 packages/lib/server-only/document/send-completed-email.ts (+12 -7)
📝 packages/lib/types/document-email.ts (+4 -0)
📝 packages/ui/components/document/document-email-checkboxes.tsx (+42 -1)

📄 Description

Description

Adds a new ownerDocumentCompleted to the email settings that controls whether a document will be sent to the owner upon completion.

This was previously the only email you couldn't disable and didn't account for users integrating with just the API and Webhooks.

Also adds a flag to the public sendDocument endpoint which will adjust this setting while sendint the document for users who aren't using emailSettings on the createDocument endpoint.

Customer reported

Changes Made

Added ownerDocumentCompleted to emailSettings meta
Updated the UI to include a new checkbox that corresponds to ownerDocumentCompleted
Added support in the API for setting ownerDocumentCompleted within the sendDocument endpoint

Testing Performed

E2E tests were written for the sendDocument endpoint
Other manually ran tests were performed to confirm email sending provided a set of scenarios and configurations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1534 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/12/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/add-owner-completed-email-setting` --- ### 📝 Commits (1) - [`efd6531`](https://github.com/documenso/documenso/commit/efd6531d3e0a726d07a3f539729f2d157d5b805c) feat: add controls for sending completion emails to document owners ### 📊 Changes **6 files changed** (+241 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/v1/implementation.ts` (+41 -57) 📝 `packages/api/v1/schema.ts` (+5 -1) ➕ `packages/app-tests/e2e/api/v1/document-sending.spec.ts` (+137 -0) 📝 `packages/lib/server-only/document/send-completed-email.ts` (+12 -7) 📝 `packages/lib/types/document-email.ts` (+4 -0) 📝 `packages/ui/components/document/document-email-checkboxes.tsx` (+42 -1) </details> ### 📄 Description ## Description Adds a new `ownerDocumentCompleted` to the email settings that controls whether a document will be sent to the owner upon completion. This was previously the only email you couldn't disable and didn't account for users integrating with just the API and Webhooks. Also adds a flag to the public `sendDocument` endpoint which will adjust this setting while sendint the document for users who aren't using `emailSettings` on the `createDocument` endpoint. ## Related Issue Customer reported ## Changes Made - Added `ownerDocumentCompleted` to emailSettings meta - Updated the UI to include a new checkbox that corresponds to `ownerDocumentCompleted` - Added support in the API for setting `ownerDocumentCompleted` within the `sendDocument` endpoint ## Testing Performed - E2E tests were written for the `sendDocument` endpoint - Other manually ran tests were performed to confirm email sending provided a set of scenarios and configurations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:30:41 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:07 +03:00

[PR #1699] [MERGED] fix: adjust desktop nav search button width and spacing #1800

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1698

No description provided.

Rows
Columns