[PR #1290] [MERGED] feat: signing order #1534

New issue

Closed

opened 2026-02-26 19:33:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1290
Author: @ephraimduncan
Created: 8/15/2024
Status: ✅ Merged
Merged: 9/16/2024
Merged by: @Mythie

Base: main ← Head: signing-order

📝 Commits (10+)

c14393b chore: checkbox and signing order input
b8c052c chore: drag and drop for signers
fc9f83d chore: delete test drag page
5ee3e6a chore: persist signing order
1118ef7 feat: send emails sequentially
e5ff167 feat: disable complete/viewed if it is not the signers turn
0e3ab0f fix: last element disappearing when you reorder
7bf5f1f chore: sort recipients on add fields
00094b6 fix: change signing number to autodrag
b9de23f fix: unable to change input text

📊 Changes

66 files changed (+2000 additions, -607 deletions)

View changed files

➕ .cursorrules (+48 -0)
📝 apps/marketing/src/app/(marketing)/singleplayer/client.tsx (+1 -0)
📝 apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx (+31 -9)
📝 apps/web/src/app/(dashboard)/templates/[id]/edit-template.tsx (+27 -5)
📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+10 -1)
📝 apps/web/src/app/(signing)/sign/[token]/page.tsx (+8 -0)
📝 apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx (+3 -0)
📝 apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx (+3 -0)
➕ apps/web/src/app/(signing)/sign/[token]/waiting/page.tsx (+100 -0)
📝 apps/web/src/app/embed/base-schema.ts (+4 -1)
📝 apps/web/src/app/embed/completed.tsx (+6 -3)
📝 apps/web/src/app/embed/direct/[[...url]]/client.tsx (+11 -11)
📝 apps/web/src/app/embed/direct/[[...url]]/not-found.tsx (+1 -1)
📝 apps/web/src/app/embed/direct/[[...url]]/page.tsx (+1 -5)
📝 apps/web/src/app/embed/document-fields.tsx (+1 -1)
📝 apps/web/src/app/embed/paywall.tsx (+6 -4)
📝 apps/web/src/app/embed/sign/[[...url]]/client.tsx (+16 -14)
📝 apps/web/src/app/embed/sign/[[...url]]/not-found.tsx (+1 -1)
📝 apps/web/src/app/embed/sign/[[...url]]/page.tsx (+10 -5)
📝 apps/web/src/middleware.ts (+1 -1)

...and 46 more files

📄 Description

https://github.com/user-attachments/assets/439ca3f0-150e-4685-858f-5f136bd7a5ac

Summary by CodeRabbit

New Features
- Introduced a signing order feature for document signing, allowing users to specify the order in which signers will receive documents.
- Enhanced document editing with the ability to manage signing order directly in the submission workflow.
- Implemented drag-and-drop functionality for reordering signers, updating their signing orders accordingly.
- Expanded localization strings to support the signing order feature in multiple languages.
- Added comprehensive coding guidelines and best practices for TypeScript development.
Bug Fixes
- Improved handling of recipient signing order to ensure that signing actions respect the specified order.
Documentation
- Updated localization strings to reflect new features and improve user experience.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1290 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 8/15/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `signing-order` --- ### 📝 Commits (10+) - [`c14393b`](https://github.com/documenso/documenso/commit/c14393b6d9d3cc091a39c681203c741247740675) chore: checkbox and signing order input - [`b8c052c`](https://github.com/documenso/documenso/commit/b8c052cab10cd7fb6f5e7a69a099e19d9cc16de0) chore: drag and drop for signers - [`fc9f83d`](https://github.com/documenso/documenso/commit/fc9f83d1c435d9f2d0c7c4a971705db9ec147c0e) chore: delete test drag page - [`5ee3e6a`](https://github.com/documenso/documenso/commit/5ee3e6a59f8bab570a40a45e48da1e2fe408ba56) chore: persist signing order - [`1118ef7`](https://github.com/documenso/documenso/commit/1118ef715f3bcb2201491fb8c7fe870df105ef31) feat: send emails sequentially - [`e5ff167`](https://github.com/documenso/documenso/commit/e5ff167a8ea7e7c710b94e420cf9d2ef0e32f8df) feat: disable complete/viewed if it is not the signers turn - [`0e3ab0f`](https://github.com/documenso/documenso/commit/0e3ab0f36d4cacb914f727ccfe84bd8b305b8d1b) fix: last element disappearing when you reorder - [`7bf5f1f`](https://github.com/documenso/documenso/commit/7bf5f1f278a834aa2a1a10843e443b859ea374ce) chore: sort recipients on add fields - [`00094b6`](https://github.com/documenso/documenso/commit/00094b61fd7e0c6a2bc2bebf91198e3da4a3a9c3) fix: change signing number to autodrag - [`b9de23f`](https://github.com/documenso/documenso/commit/b9de23f4cc311a8f1a20971eb1e0cfaef8b7e4e5) fix: unable to change input text ### 📊 Changes **66 files changed** (+2000 additions, -607 deletions) <details> <summary>View changed files</summary> ➕ `.cursorrules` (+48 -0) 📝 `apps/marketing/src/app/(marketing)/singleplayer/client.tsx` (+1 -0) 📝 `apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx` (+31 -9) 📝 `apps/web/src/app/(dashboard)/templates/[id]/edit-template.tsx` (+27 -5) 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+10 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/page.tsx` (+8 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/sign-dialog.tsx` (+3 -0) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx` (+3 -0) ➕ `apps/web/src/app/(signing)/sign/[token]/waiting/page.tsx` (+100 -0) 📝 `apps/web/src/app/embed/base-schema.ts` (+4 -1) 📝 `apps/web/src/app/embed/completed.tsx` (+6 -3) 📝 `apps/web/src/app/embed/direct/[[...url]]/client.tsx` (+11 -11) 📝 `apps/web/src/app/embed/direct/[[...url]]/not-found.tsx` (+1 -1) 📝 `apps/web/src/app/embed/direct/[[...url]]/page.tsx` (+1 -5) 📝 `apps/web/src/app/embed/document-fields.tsx` (+1 -1) 📝 `apps/web/src/app/embed/paywall.tsx` (+6 -4) 📝 `apps/web/src/app/embed/sign/[[...url]]/client.tsx` (+16 -14) 📝 `apps/web/src/app/embed/sign/[[...url]]/not-found.tsx` (+1 -1) 📝 `apps/web/src/app/embed/sign/[[...url]]/page.tsx` (+10 -5) 📝 `apps/web/src/middleware.ts` (+1 -1) _...and 46 more files_ </details> ### 📄 Description https://github.com/user-attachments/assets/439ca3f0-150e-4685-858f-5f136bd7a5ac  ## Summary by CodeRabbit - **New Features** - Introduced a signing order feature for document signing, allowing users to specify the order in which signers will receive documents. - Enhanced document editing with the ability to manage signing order directly in the submission workflow. - Implemented drag-and-drop functionality for reordering signers, updating their signing orders accordingly. - Expanded localization strings to support the signing order feature in multiple languages. - Added comprehensive coding guidelines and best practices for TypeScript development. - **Bug Fixes** - Improved handling of recipient signing order to ensure that signing actions respect the specified order. - **Documentation** - Updated localization strings to reflect new features and improve user experience.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:40 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:41 +03:00

[PR #1534] [MERGED] feat: add controls for sending completion emails to document owners #1698

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1534

No description provided.

Rows
Columns