starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-24 21:36:01 +03:00

[GH-ISSUE #603] Document Sharing Link Redirects to Homepage #163

New issue

Open

opened 2026-02-26 18:45:40 +03:00 by kerem · 7 comments

kerem commented

2026-02-26 18:45:40 +03:00

Owner

Originally created by @daallgeier on GitHub (Oct 28, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/603

Originally assigned to: @daallgeier, @luckyklyist on GitHub.

Issue Description

Opening a sharing link to a document throws a console error and redirects to documenso.com (example my pledge: https://app.documenso.com/share/sdwlb8c7t1pkvu)

8593596e-8fa50b0cbb75b2d0.js:9 Uncaught Error: Minified React error #419; visit https://reactjs.org/docs/error-decoder.html?invariant=419 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at 8593596e-8fa50b0cbb75b2d0.js:9:63944
    at Qh (8593596e-8fa50b0cbb75b2d0.js:9:64832)
    at rx (8593596e-8fa50b0cbb75b2d0.js:9:120339)
    at Lk (8593596e-8fa50b0cbb75b2d0.js:9:94328)
    at 8593596e-8fa50b0cbb75b2d0.js:9:94150
    at bf (8593596e-8fa50b0cbb75b2d0.js:9:94157)
    at mf (8593596e-8fa50b0cbb75b2d0.js:9:90680)
    at MessagePort.P (499-e5ab349bd0ad5c7b.js:25:1665)
(anonymous) @ 8593596e-8fa50b0cbb75b2d0.js:9
Qh @ 8593596e-8fa50b0cbb75b2d0.js:9
rx @ 8593596e-8fa50b0cbb75b2d0.js:9
Lk @ 8593596e-8fa50b0cbb75b2d0.js:9
(anonymous) @ 8593596e-8fa50b0cbb75b2d0.js:9
bf @ 8593596e-8fa50b0cbb75b2d0.js:9
mf @ 8593596e-8fa50b0cbb75b2d0.js:9
P @ 499-e5ab349bd0ad5c7b.js:25

Steps to Reproduce

go to /documents
Click the "share" button (wait for wayyy too long for it to be copied into clipboard)
Paste into new (incognito) tab
Get redirected to documenso.com

Expected Behavior

I expected to see my signed supporter pledge

Current Behavior

I am seeing the homepage

Screenshots (optional)

Environment

OS: macOS Sonoma
Browser: Chrome
Version: 118

Checklist

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.

Originally created by @daallgeier on GitHub (Oct 28, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/603 Originally assigned to: @daallgeier, @luckyklyist on GitHub.  ## Issue Description Opening a sharing link to a document throws a console error and redirects to documenso.com (example my pledge: https://app.documenso.com/share/sdwlb8c7t1pkvu) ``` 8593596e-8fa50b0cbb75b2d0.js:9 Uncaught Error: Minified React error #419; visit https://reactjs.org/docs/error-decoder.html?invariant=419 for the full message or use the non-minified dev environment for full errors and additional helpful warnings. at 8593596e-8fa50b0cbb75b2d0.js:9:63944 at Qh (8593596e-8fa50b0cbb75b2d0.js:9:64832) at rx (8593596e-8fa50b0cbb75b2d0.js:9:120339) at Lk (8593596e-8fa50b0cbb75b2d0.js:9:94328) at 8593596e-8fa50b0cbb75b2d0.js:9:94150 at bf (8593596e-8fa50b0cbb75b2d0.js:9:94157) at mf (8593596e-8fa50b0cbb75b2d0.js:9:90680) at MessagePort.P (499-e5ab349bd0ad5c7b.js:25:1665) (anonymous) @ 8593596e-8fa50b0cbb75b2d0.js:9 Qh @ 8593596e-8fa50b0cbb75b2d0.js:9 rx @ 8593596e-8fa50b0cbb75b2d0.js:9 Lk @ 8593596e-8fa50b0cbb75b2d0.js:9 (anonymous) @ 8593596e-8fa50b0cbb75b2d0.js:9 bf @ 8593596e-8fa50b0cbb75b2d0.js:9 mf @ 8593596e-8fa50b0cbb75b2d0.js:9 P @ 499-e5ab349bd0ad5c7b.js:25 ```  ## Steps to Reproduce   1. go to /documents 2. Click the "share" button (wait for wayyy too long for it to be copied into clipboard) 3. Paste into new (incognito) tab 4. Get redirected to documenso.com ## Expected Behavior  I expected to see my signed supporter pledge ## Current Behavior  I am seeing the homepage ## Screenshots (optional)  ## Environment  - OS: macOS Sonoma - Browser: Chrome - Version: 118 ## Checklist   - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [x] I have included any relevant screenshots. - [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution.

kerem added the

labels

2026-02-26 18:45:40 +03:00

kerem commented

2026-02-26 18:45:40 +03:00

Author

Owner

@mittalsam98 commented on GitHub (Oct 29, 2023):

I would like to pick this up

@mittalsam98 commented on GitHub (Oct 29, 2023): I would like to pick this up

kerem commented

2026-02-26 18:45:40 +03:00

Author

Owner

@Mythie commented on GitHub (Oct 30, 2023):

G'day, this one while not a bug does pose the question about phrasing.

Sharing is intended to be used for some minor virality, the intention is that people that have enjoyed the signing experience can share that by receiving a link that'll show that they've signed with Documenso with their signature or name displayed.

Problem is in the document dashboard this isn't inherently obvious:

One might assume that sharing could be used to invite a recipient to sign a document which isn't the case, to improve upon this we should use the same sharing dialog that we have elsewhere in the app:

One way to do this would be to allow the document share button to take in an optional children prop which will override the dialog trigger if provided.

@Mythie commented on GitHub (Oct 30, 2023): G'day, this one while not a bug does pose the question about phrasing. Sharing is intended to be used for some minor virality, the intention is that people that have enjoyed the signing experience can share that by receiving a link that'll show that they've signed with Documenso with their signature or name displayed. <img width="599" alt="image" src="https://github.com/documenso/documenso/assets/13398220/f5a04bee-11cf-434f-bebd-c263a336ea58"> Problem is in the document dashboard this isn't inherently obvious: <img width="1219" alt="image" src="https://github.com/documenso/documenso/assets/13398220/32c0fe90-5070-4c7c-ac4e-1885f4025b04"> One might assume that sharing could be used to invite a recipient to sign a document which isn't the case, to improve upon this we should use the same sharing dialog that we have elsewhere in the app: <img width="648" alt="image" src="https://github.com/documenso/documenso/assets/13398220/cb8b66bf-1d13-4786-a1b5-cdcdf7b09311"> One way to do this would be to allow the document share button to take in an optional children prop which will override the dialog trigger if provided.

kerem commented

2026-02-26 18:45:40 +03:00

Author

Owner

@Mythie commented on GitHub (Oct 30, 2023):

@mittalsam98 If you're confident you can make these changes I'm happy to assign it to you 🙌

@Mythie commented on GitHub (Oct 30, 2023): @mittalsam98 If you're confident you can make these changes I'm happy to assign it to you 🙌

kerem commented

2026-02-26 18:45:40 +03:00

Author

Owner

@daallgeier commented on GitHub (Oct 30, 2023):

the "it" in the suggested tweet seems to refer to the document tho. Could that be rewritten too?

I just signed a document with @documenso.  Check them out!

[url]

Oh and it could be referral link to maybe get one more free document this month.

@daallgeier commented on GitHub (Oct 30, 2023): the "it" in the suggested tweet seems to refer to the document tho. Could that be rewritten too? ``` I just signed a document with @documenso. Check them out! [url] ``` Oh and it could be referral link to maybe get one more free document this month.

kerem commented

2026-02-26 18:45:40 +03:00

Author

Owner

@luckyklyist commented on GitHub (Oct 30, 2023):

@mittalsam98 If you're confident you can make these changes I'm happy to assign it to you 🙌

I will liked to look into this issue .

@luckyklyist commented on GitHub (Oct 30, 2023): > @mittalsam98 If you're confident you can make these changes I'm happy to assign it to you 🙌 I will liked to look into this issue .

kerem commented

2026-02-26 18:45:40 +03:00

Author

Owner

@Mythie commented on GitHub (Oct 31, 2023):

@mittalsam98 giving this to @luckyklyist apologies!

@Mythie commented on GitHub (Oct 31, 2023): @mittalsam98 giving this to @luckyklyist apologies!

kerem commented

2026-02-26 18:45:40 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Dec 8, 2023):

This issue has not seen activity for a while. It will be closed in 30 days unless further activity is detected

@github-actions[bot] commented on GitHub (Dec 8, 2023): This issue has not seen activity for a while. It will be closed in 30 days unless further activity is detected

kerem referenced this issue

2026-02-26 18:48:50 +03:00

[PR #163] [MERGED] We are LIVE on Product Hunt 🚨 Come say hi :) #766

kerem referenced this issue

2026-02-26 18:48:59 +03:00

[PR #218] [MERGED] Release 0.9.1 #802

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#163

No description provided.

Rows
Columns