starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[GH-ISSUE #2100] i18n: Missing context for "Original" and "Signed" strings in EnvelopeDownloadDialog #603

New issue

Closed

opened 2026-02-26 18:47:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 18:47:45 +03:00

Owner

Originally created by @mKoonrad on GitHub (Oct 24, 2025).
Original GitHub issue: https://github.com/documenso/documenso/issues/2100

Issue Description

In the EnvelopeDownloadDialog component (file apps/website/src/components/envelope/envelope-download-dialog.tsx), strings
github.com/documenso/documenso@47bdcd833f/apps/remix/app/components/dialogs/envelope-download-dialog.tsx (L195)
and
github.com/documenso/documenso@47bdcd833f/apps/remix/app/components/dialogs/envelope-download-dialog.tsx (L209)
are used as labels for download buttons.

These strings lack translation context. In many languages (like Polish), these words function as adjectives that must agree with a noun (in this case, "document").

For example, "Signed" could be translated as:

Podpisano (a past-tense verb, meaning "It was signed")
Podpisany (an adjective, meaning "The signed [document]")

The correct translation in this context is the adjective form ("Podpisany"). Without context, translators are likely to choose the wrong form, especially since lingui merge this string with other instances of "Signed" used in a different context (e.g., as a verb). Adding a context to the <Trans> component will solve this ambiguity.

Steps to Reproduce

Go to any envelope.
Click the "Download" button to open the download modal.
Observe the two buttons for downloading different versions of the file.

Expected Behavior

The <Trans> components for both strings should include a context prop to provide clear context

<Trans context="Original document (adjective)">Original</Trans>
<Trans context="Signed document (adjective)">Signed</Trans>

Current Behavior

No response

Screenshots (optional)

No response

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome

Version [e.g., 2.0.1]

v1.13.1

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @mKoonrad on GitHub (Oct 24, 2025). Original GitHub issue: https://github.com/documenso/documenso/issues/2100 ### Issue Description In the `EnvelopeDownloadDialog` component (file [apps/website/src/components/envelope/envelope-download-dialog.tsx](https://github.com/documenso/documenso/blob/47bdcd833f5a7469abcf3bd9ae0307a8b10ed073/apps/remix/app/components/dialogs/envelope-download-dialog.tsx#L4)), strings https://github.com/documenso/documenso/blob/47bdcd833f5a7469abcf3bd9ae0307a8b10ed073/apps/remix/app/components/dialogs/envelope-download-dialog.tsx#L195 and https://github.com/documenso/documenso/blob/47bdcd833f5a7469abcf3bd9ae0307a8b10ed073/apps/remix/app/components/dialogs/envelope-download-dialog.tsx#L209 are used as labels for download buttons. These strings lack translation context. In many languages (like Polish), these words function as adjectives that must agree with a noun (in this case, "document"). For example, "Signed" could be translated as: - `Podpisano` (a past-tense verb, meaning "It was signed") - `Podpisany` (an adjective, meaning "The signed [document]") The correct translation in this context is the adjective form ("Podpisany"). Without context, translators are likely to choose the wrong form, especially since lingui merge this string with other instances of "Signed" used in a different context (e.g., as a verb). Adding a context to the `<Trans>` component will solve this ambiguity. ### Steps to Reproduce 1. Go to any envelope. 2. Click the "Download" button to open the download modal. 3. Observe the two buttons for downloading different versions of the file. ### Expected Behavior The `<Trans>` components for both strings should include a context prop to provide clear context `<Trans context="Original document (adjective)">Original</Trans>` `<Trans context="Signed document (adjective)">Signed</Trans>` ### Current Behavior _No response_ ### Screenshots (optional) _No response_ ### Operating System [e.g., Windows 10] Windows 11 ### Browser [e.g., Chrome, Firefox] Chrome ### Version [e.g., 2.0.1] v1.13.1 ### Please check the boxes that apply to this issue report. - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [ ] I have included any relevant screenshots. - [x] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [x] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:47:45 +03:00

closed this issue
added the
status: triage
label

kerem referenced this issue

2026-02-26 19:31:44 +03:00

[PR #615] [MERGED] fix: added the share btn in the UI and prewarm fetch #1079

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#603

No description provided.

Rows
Columns