[PR #1437] [MERGED] feat: add document distribution setting #1627

Closed
opened 2026-02-26 19:34:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1437
Author: @dguyen
Created: 11/4/2024
Status: Merged
Merged: 11/8/2024
Merged by: @dguyen

Base: mainHead: feat/add-document-distribution-setting


📝 Commits (4)

  • 488aeeb feat: add document email settings
  • 8050cad fix: bugs
  • d3a7ca9 Merge branch 'main' into feat/add-document-distribution-setting
  • 0326d81 fix: stuff

📊 Changes

32 files changed (+926 additions, -175 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx (+25 -9)
📝 apps/web/src/app/(dashboard)/templates/data-table-templates.tsx (+1 -0)
📝 apps/web/src/app/(dashboard)/templates/use-template-dialog.tsx (+80 -34)
📝 packages/app-tests/e2e/document-flow/stepper-component.spec.ts (+4 -4)
📝 packages/lib/constants/document.ts (+17 -1)
📝 packages/lib/jobs/definitions/emails/send-signing-email.ts (+9 -0)
📝 packages/lib/server-only/document-meta/upsert-document-meta.ts (+10 -1)
📝 packages/lib/server-only/document/delete-document.ts (+9 -0)
📝 packages/lib/server-only/document/resend-document.tsx (+9 -0)
📝 packages/lib/server-only/document/send-completed-email.ts (+14 -2)
📝 packages/lib/server-only/document/send-delete-email.ts (+10 -0)
📝 packages/lib/server-only/document/send-document.tsx (+10 -2)
📝 packages/lib/server-only/document/send-pending-email.ts (+9 -0)
📝 packages/lib/server-only/document/super-delete-document.ts (+10 -1)
📝 packages/lib/server-only/recipient/set-recipients-for-document.ts (+6 -1)
📝 packages/lib/server-only/template/create-document-from-direct-template.ts (+1 -0)
📝 packages/lib/server-only/template/create-document-from-template.ts (+5 -0)
📝 packages/lib/server-only/template/duplicate-template.ts (+4 -1)
📝 packages/lib/server-only/template/find-templates.ts (+1 -0)
📝 packages/lib/server-only/template/update-template-settings.ts (+2 -0)

...and 12 more files

📄 Description

Description

Add a document distribution setting which will allow us to further configure how recipients currently receive documents.

Testing Performed

Tested that templates pass along meta
Tested that created documents from templates pass along meta and follow rules
Tested that created documents from direct templates pass along meta and follow rules
Tested that documents created follow email rules

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced document submission process with improved notifications for different distribution methods (Email and Signing Links).
    • Introduced a tabbed interface for selecting document distribution methods in forms.
    • Added a new component for managing document email settings with checkboxes for various email events.
    • New enum for document distribution methods (EMAIL and NONE) added to enhance functionality.
    • Enhanced forms with dynamic rendering based on selected distribution methods, improving user experience.
  • Bug Fixes

    • Updated email sending logic to ensure emails are sent only when appropriate based on document settings.
  • Documentation

    • Improved documentation for email settings and document distribution methods.
  • Chores

    • Added new types and constants to support document distribution features.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1437 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/8/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `feat/add-document-distribution-setting` --- ### 📝 Commits (4) - [`488aeeb`](https://github.com/documenso/documenso/commit/488aeebc6c9071b0e08a048f538239783ad9506a) feat: add document email settings - [`8050cad`](https://github.com/documenso/documenso/commit/8050cad02ed28301fed11172e538618fa648a480) fix: bugs - [`d3a7ca9`](https://github.com/documenso/documenso/commit/d3a7ca90542bca59a8a8d6083ad5cfe6ff046538) Merge branch 'main' into feat/add-document-distribution-setting - [`0326d81`](https://github.com/documenso/documenso/commit/0326d81d45c8840e22018ebae15faf3ccdbdf1a7) fix: stuff ### 📊 Changes **32 files changed** (+926 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/[id]/edit-document.tsx` (+25 -9) 📝 `apps/web/src/app/(dashboard)/templates/data-table-templates.tsx` (+1 -0) 📝 `apps/web/src/app/(dashboard)/templates/use-template-dialog.tsx` (+80 -34) 📝 `packages/app-tests/e2e/document-flow/stepper-component.spec.ts` (+4 -4) 📝 `packages/lib/constants/document.ts` (+17 -1) 📝 `packages/lib/jobs/definitions/emails/send-signing-email.ts` (+9 -0) 📝 `packages/lib/server-only/document-meta/upsert-document-meta.ts` (+10 -1) 📝 `packages/lib/server-only/document/delete-document.ts` (+9 -0) 📝 `packages/lib/server-only/document/resend-document.tsx` (+9 -0) 📝 `packages/lib/server-only/document/send-completed-email.ts` (+14 -2) 📝 `packages/lib/server-only/document/send-delete-email.ts` (+10 -0) 📝 `packages/lib/server-only/document/send-document.tsx` (+10 -2) 📝 `packages/lib/server-only/document/send-pending-email.ts` (+9 -0) 📝 `packages/lib/server-only/document/super-delete-document.ts` (+10 -1) 📝 `packages/lib/server-only/recipient/set-recipients-for-document.ts` (+6 -1) 📝 `packages/lib/server-only/template/create-document-from-direct-template.ts` (+1 -0) 📝 `packages/lib/server-only/template/create-document-from-template.ts` (+5 -0) 📝 `packages/lib/server-only/template/duplicate-template.ts` (+4 -1) 📝 `packages/lib/server-only/template/find-templates.ts` (+1 -0) 📝 `packages/lib/server-only/template/update-template-settings.ts` (+2 -0) _...and 12 more files_ </details> ### 📄 Description ## Description Add a document distribution setting which will allow us to further configure how recipients currently receive documents. ## Testing Performed Tested that templates pass along meta Tested that created documents from templates pass along meta and follow rules Tested that created documents from direct templates pass along meta and follow rules Tested that documents created follow email rules <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced document submission process with improved notifications for different distribution methods (Email and Signing Links). - Introduced a tabbed interface for selecting document distribution methods in forms. - Added a new component for managing document email settings with checkboxes for various email events. - New enum for document distribution methods (EMAIL and NONE) added to enhance functionality. - Enhanced forms with dynamic rendering based on selected distribution methods, improving user experience. - **Bug Fixes** - Updated email sending logic to ensure emails are sent only when appropriate based on document settings. - **Documentation** - Improved documentation for email settings and document distribution methods. - **Chores** - Added new types and constants to support document distribution features. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:34:04 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1627
No description provided.