starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #1162] [MERGED] fix: truncation of titles to fix UI breaks #1437

New issue

Closed

opened 2026-02-26 19:33:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1162
Author: @rhit-daviscl
Created: 5/16/2024
Status: ✅ Merged
Merged: 7/29/2024
Merged by: @Mythie

Base: main ← Head: field-truncation

📝 Commits (9)

a62af7b fix: name field trucation
b637462 fix: name field hover to display whole name
607d5fe fix: truncation inside the document view
682758c fix: trancation issue in audit log header
aa34622 fix: truncation issue in recent activity log
15efc73 fix: truncation issue on sign as popup
73f69fc fix: truncation issue on sign page
ce3dd1e Merge branch 'documenso:main' into field-truncation
5a228b9 Merge branch 'main' into field-truncation

📊 Changes

9 files changed (+43 additions, -17 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recent-activity.tsx (+6 -1)
📝 apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx (+1 -1)
📝 apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/name-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/signature-field.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx (+12 -9)
📝 apps/web/src/components/(dashboard)/layout/header.tsx (+17 -1)
📝 packages/ui/primitives/avatar.tsx (+3 -1)
📝 packages/ui/primitives/dialog.tsx (+1 -1)

📄 Description

Description

This pull request introduces the addition of CSS properties which will allow for the display of long titles in most sections not already implemented. This enhancement allows users to see their full screen without breaking the UI for having a long input.

Fixes #950

Changes Made

Added a truncate CSS field to most document views and *-field classes
Changed spans to div in in *-field classes to better truncate
Added a hover effect where it displays the truncated text if the mouse hovers over the truncated name (in many places)

Testing Performed

Tested by giving the User a long name and seeing if the UI displays it all for truncates it.
Tested by giving a document a long name and see if the UI displays it all for truncate it.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

No additional notes.

Summary by CodeRabbit

New Features
- Enhanced rendering of text in various components, improving readability and hover context with truncation support.
- Improved layout and styling of document titles and user invitations in the signing process.
Bug Fixes
- Addressed layout issues by ensuring text truncation in key components for better responsive design.
Documentation
- Updated internal logic for determining the selected team in the header component.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1162 **Author:** [@rhit-daviscl](https://github.com/rhit-daviscl) **Created:** 5/16/2024 **Status:** ✅ Merged **Merged:** 7/29/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `field-truncation` --- ### 📝 Commits (9) - [`a62af7b`](https://github.com/documenso/documenso/commit/a62af7b73988a8f569f73bf97b1fb2945bebfd67) fix: name field trucation - [`b637462`](https://github.com/documenso/documenso/commit/b637462269aa6d5e94f62d480d7cccea57e5571e) fix: name field hover to display whole name - [`607d5fe`](https://github.com/documenso/documenso/commit/607d5fee8550adf8f3b52dafb43578d71b1fbaa7) fix: truncation inside the document view - [`682758c`](https://github.com/documenso/documenso/commit/682758c698294693f939efae17cf61a632b0bfbf) fix: trancation issue in audit log header - [`aa34622`](https://github.com/documenso/documenso/commit/aa34622bd0cb7289f6840bf4bc9b4127cd5bb587) fix: truncation issue in recent activity log - [`15efc73`](https://github.com/documenso/documenso/commit/15efc7315ae8dc9154b3d6425eb7777996d2115d) fix: truncation issue on sign as popup - [`73f69fc`](https://github.com/documenso/documenso/commit/73f69fc3b3278e3b017e060464cca0d22496c7b4) fix: truncation issue on sign page - [`ce3dd1e`](https://github.com/documenso/documenso/commit/ce3dd1eeedb9a72e6111051c3cc4bb4403ecf894) Merge branch 'documenso:main' into field-truncation - [`5a228b9`](https://github.com/documenso/documenso/commit/5a228b945016cbe7edadea2b49740b30eb19944d) Merge branch 'main' into field-truncation ### 📊 Changes **9 files changed** (+43 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recent-activity.tsx` (+6 -1) 📝 `apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx` (+1 -1) 📝 `apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/name-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/signature-field.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx` (+12 -9) 📝 `apps/web/src/components/(dashboard)/layout/header.tsx` (+17 -1) 📝 `packages/ui/primitives/avatar.tsx` (+3 -1) 📝 `packages/ui/primitives/dialog.tsx` (+1 -1) </details> ### 📄 Description ## Description  This pull request introduces the addition of CSS properties which will allow for the display of long titles in most sections not already implemented. This enhancement allows users to see their full screen without breaking the UI for having a long input.  ![Example](https://github.com/documenso/documenso/assets/73263545/e71acdfc-6e6f-49ed-afcc-37fe832895e1) ## Related Issue  Fixes #950  ## Changes Made   - Added a truncate CSS field to most document views and *-field classes - Changed spans to div in in *-field classes to better truncate - Added a hover effect where it displays the truncated text if the mouse hovers over the truncated name (in many places) ## Testing Performed   - Tested by giving the User a long name and seeing if the UI displays it all for truncates it. - Tested by giving a document a long name and see if the UI displays it all for truncate it. ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes  No additional notes.   ## Summary by CodeRabbit - **New Features** - Enhanced rendering of text in various components, improving readability and hover context with truncation support. - Improved layout and styling of document titles and user invitations in the signing process. - **Bug Fixes** - Addressed layout issues by ensuring text truncation in key components for better responsive design. - **Documentation** - Updated internal logic for determining the selected team in the header component.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:14 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:34:04 +03:00

[PR #1437] [MERGED] feat: add document distribution setting #1627

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1437

No description provided.

Rows
Columns