[PR #1425] [MERGED] fix: missing signing order when using templates #1622

New issue

Closed

opened 2026-02-26 19:34:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:34:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1425
Author: @dguyen
Created: 10/28/2024
Status: ✅ Merged
Merged: 11/3/2024
Merged by: @dguyen

Base: main ← Head: fix/template-signing-order

📝 Commits (1)

07d2d62 fix: missing signing order when using templates

📊 Changes

2 files changed (+10 additions, -1 deletions)

View changed files

📝 packages/lib/server-only/template/create-document-from-direct-template.ts (+5 -0)
📝 packages/lib/server-only/template/create-document-from-template.ts (+5 -1)

📄 Description

Description

Currently when using a template with the signing sequence enabled, the created document will not have the sequence enabled.

These changes resolves that by passing along the required meta data and recipient data to the created document from the template.

Should resolve #1398

Summary by CodeRabbit

New Features
- Enhanced document creation from templates with a new signing order feature for recipients.
- Recipients can now have a specified signing order, improving the management of document signing processes.
Bug Fixes
- Improved error handling for template validity and recipient roles, ensuring a smoother document creation experience.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1425 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 11/3/2024 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/template-signing-order` --- ### 📝 Commits (1) - [`07d2d62`](https://github.com/documenso/documenso/commit/07d2d62264976820a34dd74d6342440408794ce3) fix: missing signing order when using templates ### 📊 Changes **2 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/template/create-document-from-direct-template.ts` (+5 -0) 📝 `packages/lib/server-only/template/create-document-from-template.ts` (+5 -1) </details> ### 📄 Description ## Description Currently when using a template with the signing sequence enabled, the created document will not have the sequence enabled. These changes resolves that by passing along the required meta data and recipient data to the created document from the template. Should resolve #1398  ## Summary by CodeRabbit - **New Features** - Enhanced document creation from templates with a new signing order feature for recipients. - Recipients can now have a specified signing order, improving the management of document signing processes. - **Bug Fixes** - Improved error handling for template validity and recipient roles, ensuring a smoother document creation experience.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:34:02 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:30:56 +03:00

[PR #1622] [MERGED] chore: update local seed data #1759

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1622

No description provided.

Rows
Columns