[PR #1114] [MERGED] fix: disable cert download #1398

Closed
opened 2026-02-26 19:33:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1114
Author: @dguyen
Created: 4/24/2024
Status: Merged
Merged: 4/25/2024
Merged by: @Mythie

Base: mainHead: fix/disable-cert-download


📝 Commits (2)

  • 41ed6c9 fix: disable cert download when document not complete
  • e4cf9c8 fix: add server logic

📊 Changes

3 files changed (+15 additions, -1 deletions)

View changed files

📝 apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx (+5 -1)
📝 apps/web/src/app/(dashboard)/documents/[id]/logs/download-certificate-button.tsx (+4 -0)
📝 packages/trpc/server/document-router/router.ts (+6 -0)

📄 Description

Description

Disable the document certificate download button when the document is not complete

Changes Made

  • Disable UI button
  • Disable TRPC API endpoint

Testing Performed

Tested locally for pending, draft and completed documents


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1114 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 4/24/2024 **Status:** ✅ Merged **Merged:** 4/25/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/disable-cert-download` --- ### 📝 Commits (2) - [`41ed6c9`](https://github.com/documenso/documenso/commit/41ed6c9ad7f34c9ea430808a8e4f5cf95d9e7037) fix: disable cert download when document not complete - [`e4cf9c8`](https://github.com/documenso/documenso/commit/e4cf9c82518a6f38ca1626c8899c89abe92efa46) fix: add server logic ### 📊 Changes **3 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(dashboard)/documents/[id]/logs/document-logs-page-view.tsx` (+5 -1) 📝 `apps/web/src/app/(dashboard)/documents/[id]/logs/download-certificate-button.tsx` (+4 -0) 📝 `packages/trpc/server/document-router/router.ts` (+6 -0) </details> ### 📄 Description ## Description Disable the document certificate download button when the document is not complete ## Changes Made - Disable UI button - Disable TRPC API endpoint ## Testing Performed Tested locally for pending, draft and completed documents --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 19:33:04 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1398
No description provided.