starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1322] [MERGED] feat: embed signing experience #1557

New issue

Closed

opened 2026-02-26 19:33:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:33:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1322
Author: @Mythie
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/4/2024
Merged by: @Mythie

Base: main ← Head: feat/embed

📝 Commits (3)

1d29881 feat: embed signing experience
6745811 chore: add docs
d35f2f8 fix: update framework links

📊 Changes

39 files changed (+2090 additions, -75 deletions)

View changed files

📝 apps/documentation/pages/developers/_meta.json (+2 -1)
➕ apps/documentation/pages/developers/embedding/index.mdx (+131 -0)
➕ apps/documentation/pages/developers/embedding/preact.mdx (+77 -0)
➕ apps/documentation/pages/developers/embedding/react.mdx (+77 -0)
➕ apps/documentation/pages/developers/embedding/solid.mdx (+77 -0)
➕ apps/documentation/pages/developers/embedding/svelte.mdx (+79 -0)
➕ apps/documentation/pages/developers/embedding/vue.mdx (+79 -0)
➕ apps/documentation/public/embedding/copy-recipient-token.png (+0 -0)
➕ apps/documentation/public/embedding/enable-direct-link.png (+0 -0)
➕ apps/documentation/public/embedding/team-templates.png (+0 -0)
📝 apps/web/package.json (+1 -0)
📝 apps/web/src/app/(recipient)/d/[token]/direct-template.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx (+1 -0)
➕ apps/web/src/app/embed/authenticate.tsx (+32 -0)
➕ apps/web/src/app/embed/base-schema.ts (+5 -0)
➕ apps/web/src/app/embed/client-loading.tsx (+7 -0)
➕ apps/web/src/app/embed/completed.tsx (+33 -0)
➕ apps/web/src/app/embed/direct/[[...url]]/client.tsx (+456 -0)
➕ apps/web/src/app/embed/direct/[[...url]]/not-found.tsx (+3 -0)
➕ apps/web/src/app/embed/direct/[[...url]]/page.tsx (+97 -0)

...and 19 more files

📄 Description

Description

Filling in shortly

Changes Made

Change 1
Change 2
...

https://github.com/user-attachments/assets/6798f134-821e-4bd3-a6ee-73f3e2b2555e

Testing Performed

Tested feature X in scenario Y.
Ran unit tests for component Z.
Tested on browsers A, B, and C.
...

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Summary by CodeRabbit

New Features
- Introduced a new authentication interface for embedded document viewing.
- Added a loading overlay component to enhance user experience during loading states.
- Implemented a completion message component for documents, improving user feedback post-signing.
- Added a paywall component to manage access to specific documents.
- Enhanced the sign-in form with a customizable redirect URL after authentication.
- Expanded documentation on embedding features for various JavaScript frameworks.
Bug Fixes
- Improved handling of missing or invalid tokens and recipients, providing clearer user feedback.
Documentation
- Updated localization strings for improved user experience across various languages.
Chores
- Added new dependencies to enhance component functionalities and performance.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1322 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/4/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/embed` --- ### 📝 Commits (3) - [`1d29881`](https://github.com/documenso/documenso/commit/1d2988173f6d06a12fbb24c83b3410485243b128) feat: embed signing experience - [`6745811`](https://github.com/documenso/documenso/commit/674581110b60c19285a6e63083bfb779712c08bb) chore: add docs - [`d35f2f8`](https://github.com/documenso/documenso/commit/d35f2f8b2bb64d8b4582dc202182251a42dd29f9) fix: update framework links ### 📊 Changes **39 files changed** (+2090 additions, -75 deletions) <details> <summary>View changed files</summary> 📝 `apps/documentation/pages/developers/_meta.json` (+2 -1) ➕ `apps/documentation/pages/developers/embedding/index.mdx` (+131 -0) ➕ `apps/documentation/pages/developers/embedding/preact.mdx` (+77 -0) ➕ `apps/documentation/pages/developers/embedding/react.mdx` (+77 -0) ➕ `apps/documentation/pages/developers/embedding/solid.mdx` (+77 -0) ➕ `apps/documentation/pages/developers/embedding/svelte.mdx` (+79 -0) ➕ `apps/documentation/pages/developers/embedding/vue.mdx` (+79 -0) ➕ `apps/documentation/public/embedding/copy-recipient-token.png` (+0 -0) ➕ `apps/documentation/public/embedding/enable-direct-link.png` (+0 -0) ➕ `apps/documentation/public/embedding/team-templates.png` (+0 -0) 📝 `apps/web/package.json` (+1 -0) 📝 `apps/web/src/app/(recipient)/d/[token]/direct-template.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/signing-page-view.tsx` (+1 -0) ➕ `apps/web/src/app/embed/authenticate.tsx` (+32 -0) ➕ `apps/web/src/app/embed/base-schema.ts` (+5 -0) ➕ `apps/web/src/app/embed/client-loading.tsx` (+7 -0) ➕ `apps/web/src/app/embed/completed.tsx` (+33 -0) ➕ `apps/web/src/app/embed/direct/[[...url]]/client.tsx` (+456 -0) ➕ `apps/web/src/app/embed/direct/[[...url]]/not-found.tsx` (+3 -0) ➕ `apps/web/src/app/embed/direct/[[...url]]/page.tsx` (+97 -0) _...and 19 more files_ </details> ### 📄 Description ## Description Filling in shortly   ## Related Issue   ## Changes Made   - Change 1 - Change 2 - ... https://github.com/user-attachments/assets/6798f134-821e-4bd3-a6ee-73f3e2b2555e ## Testing Performed   - Tested feature X in scenario Y. - Ran unit tests for component Z. - Tested on browsers A, B, and C. - ... ## Checklist   - [ ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes    ## Summary by CodeRabbit - **New Features** - Introduced a new authentication interface for embedded document viewing. - Added a loading overlay component to enhance user experience during loading states. - Implemented a completion message component for documents, improving user feedback post-signing. - Added a paywall component to manage access to specific documents. - Enhanced the sign-in form with a customizable redirect URL after authentication. - Expanded documentation on embedding features for various JavaScript frameworks. - **Bug Fixes** - Improved handling of missing or invalid tokens and recipients, providing clearer user feedback. - **Documentation** - Updated localization strings for improved user experience across various languages. - **Chores** - Added new dependencies to enhance component functionalities and performance.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:33:46 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1557

No description provided.

Rows
Columns