[PR #1014] [MERGED] fix: ensure password input is cleared when 2fa enable dialog is closed #1322

New issue

Closed

opened 2026-02-26 19:32:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:32:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1014
Author: @premiare
Created: 3/10/2024
Status: ✅ Merged
Merged: 3/11/2024
Merged by: @Mythie

Base: main ← Head: fix/2fa-enable

📝 Commits (4)

f646fa2 fix: ensure password input is cleared when 2fa enable dialog is closed
6f958b9 fix: update the dialog cancel to reset
afe99e5 fix: revert reset changes, reset on open state change instead
c744482 fix: add conditional to useEffects

📊 Changes

2 files changed (+16 additions, -2 deletions)

View changed files

📝 apps/web/src/components/forms/2fa/enable-authenticator-app-dialog.tsx (+8 -1)
📝 apps/web/src/components/forms/2fa/view-recovery-codes-dialog.tsx (+8 -1)

📄 Description

Issue found by guatam in Documenso Discord.
https://discord.com/channels/1132216843537485854/1133420505030987857/1215716399822147664

Bug Loom:
https://www.loom.com/share/b7defde91dfb437580c13c7f166f59ff?sid=cbca746f-174a-44ad-997c-cf3a2eef8380

Fix Loom:
https://www.loom.com/share/8748ac47459247a49ddf7d5379e2a0a0?sid=02977122-c150-44e8-9a19-4c8356c298d7

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1014 **Author:** [@premiare](https://github.com/premiare) **Created:** 3/10/2024 **Status:** ✅ Merged **Merged:** 3/11/2024 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/2fa-enable` --- ### 📝 Commits (4) - [`f646fa2`](https://github.com/documenso/documenso/commit/f646fa29d7c1c9240810e50d9d8e72e255958be3) fix: ensure password input is cleared when 2fa enable dialog is closed - [`6f958b9`](https://github.com/documenso/documenso/commit/6f958b9320a389f92fc9c16dc7244d666752db4f) fix: update the dialog cancel to reset - [`afe99e5`](https://github.com/documenso/documenso/commit/afe99e5ec90dd1cc781280c2ad2b702be24e13fc) fix: revert reset changes, reset on open state change instead - [`c744482`](https://github.com/documenso/documenso/commit/c744482b844e8d8068489267b9256b3e321cf495) fix: add conditional to useEffects ### 📊 Changes **2 files changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/components/forms/2fa/enable-authenticator-app-dialog.tsx` (+8 -1) 📝 `apps/web/src/components/forms/2fa/view-recovery-codes-dialog.tsx` (+8 -1) </details> ### 📄 Description Issue found by guatam in Documenso Discord. https://discord.com/channels/1132216843537485854/1133420505030987857/1215716399822147664 Bug Loom: https://www.loom.com/share/b7defde91dfb437580c13c7f166f59ff?sid=cbca746f-174a-44ad-997c-cf3a2eef8380 Fix Loom: https://www.loom.com/share/8748ac47459247a49ddf7d5379e2a0a0?sid=02977122-c150-44e8-9a19-4c8356c298d7 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:32:46 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:46 +03:00

[PR #1322] [MERGED] feat: embed signing experience #1557

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1322

No description provided.

Rows
Columns