[PR #717] [CLOSED] feat: add recipient roles #1135

New issue

Closed

opened 2026-02-26 19:31:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:31:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/717
Author: @e-roy
Created: 12/3/2023
Status: ❌ Closed

Base: main ← Head: feat-recipient-roles

📝 Commits (1)

9d33741 feat: add recipient roles

📊 Changes

10 files changed (+213 additions, -96 deletions)

View changed files

📝 apps/marketing/src/app/(marketing)/singleplayer/client.tsx (+1 -0)
📝 packages/lib/server-only/recipient/set-recipients-for-document.ts (+3 -0)
📝 packages/prisma/migrations/20230404095503_initial_migration/migration.sql (+54 -39)
📝 packages/prisma/schema.prisma (+9 -0)
📝 packages/trpc/server/document-router/schema.ts (+1 -0)
📝 packages/trpc/server/recipient-router/router.ts (+1 -0)
📝 packages/trpc/server/recipient-router/schema.ts (+1 -0)
📝 packages/ui/primitives/document-flow/add-fields.tsx (+77 -52)
📝 packages/ui/primitives/document-flow/add-signers.tsx (+65 -5)
📝 packages/ui/primitives/document-flow/add-signers.types.ts (+1 -0)

📄 Description

This PR adds a Recipient Role feature for #705

4 Roles added - Signer, Approver, Recieves copy, and Viewer.

Emails go out to everyone, because it seems logicially that everyone would want to see the document, regardless if they are signing it. This would mean the email messaging would need to change also.

It seems like anyone can sign a document for any signer if they have the link to the document. I tried this on a new browser window with a different browser account. I hadn't signed into the app yet, but I could see the document and sign. I do have a little doubt that I might have done something wrong on my side, but if I'm correct, this would seem like a bug because you'd only want only the signer to sign for themselves.

Not sure if I should continue and complete the entire path, I see there is someone else that submitted for this issue also and it's getting late where I am.

Cheers,

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/717 **Author:** [@e-roy](https://github.com/e-roy) **Created:** 12/3/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat-recipient-roles` --- ### 📝 Commits (1) - [`9d33741`](https://github.com/documenso/documenso/commit/9d33741ea0354e95c6b1ee24eac4a6966b66ec82) feat: add recipient roles ### 📊 Changes **10 files changed** (+213 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `apps/marketing/src/app/(marketing)/singleplayer/client.tsx` (+1 -0) 📝 `packages/lib/server-only/recipient/set-recipients-for-document.ts` (+3 -0) 📝 `packages/prisma/migrations/20230404095503_initial_migration/migration.sql` (+54 -39) 📝 `packages/prisma/schema.prisma` (+9 -0) 📝 `packages/trpc/server/document-router/schema.ts` (+1 -0) 📝 `packages/trpc/server/recipient-router/router.ts` (+1 -0) 📝 `packages/trpc/server/recipient-router/schema.ts` (+1 -0) 📝 `packages/ui/primitives/document-flow/add-fields.tsx` (+77 -52) 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+65 -5) 📝 `packages/ui/primitives/document-flow/add-signers.types.ts` (+1 -0) </details> ### 📄 Description This PR adds a Recipient Role feature for #705 4 Roles added - Signer, Approver, Recieves copy, and Viewer. Emails go out to everyone, because it seems logicially that everyone would want to see the document, regardless if they are signing it. This would mean the email messaging would need to change also. It seems like anyone can sign a document for any signer if they have the link to the document. I tried this on a new browser window with a different browser account. I hadn't signed into the app yet, but I could see the document and sign. I do have a little doubt that I might have done something wrong on my side, but if I'm correct, this would seem like a bug because you'd only want only the signer to sign for themselves. Not sure if I should continue and complete the entire path, I see there is someone else that submitted for this issue also and it's getting late where I am. Cheers, --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:31:59 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:33:10 +03:00

[PR #1135] [MERGED] fix: dialog close on refresh #1419

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1135

No description provided.

Rows
Columns