[PR #558] [MERGED] fix(bug): name field can be updated with spaces #555 #1044

New issue

Closed

opened 2026-02-26 19:31:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 19:31:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/558
Author: @adityadeshlahre
Created: 10/14/2023
Status: ✅ Merged
Merged: 10/19/2023
Merged by: @dguyen

Base: feat/refresh ← Head: fix-555-name-field-can-be-updated-with-spaces

📝 Commits (3)

7bae000 fix(bug): fix only spaces_name sign
60c979b fix(bug): added trimStart and updated ZSignFieldWithTokenMutationSchema
cdfcbbd fix(bug): updated ZSignFieldWithTokenMutationSchema

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 apps/web/src/app/(signing)/sign/[token]/form.tsx (+1 -1)
📝 apps/web/src/app/(signing)/sign/[token]/name-field.tsx (+1 -1)
📝 packages/trpc/server/field-router/schema.ts (+1 -1)

📄 Description

fixes #555

I have fixed in two places in singup form and profile update page form.
this fix improves UX as It disabled the update profile / singup button when ever the fullname was emtpy .
as shown in video below !

[updated video]

https://www.loom.com/share/f0591258760349bc9871675a480972f4?sid=7617e340-a854-4f72-b70e-2756594686b4

If any changes required let me know !
Thank You 😄

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/558 **Author:** [@adityadeshlahre](https://github.com/adityadeshlahre) **Created:** 10/14/2023 **Status:** ✅ Merged **Merged:** 10/19/2023 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `feat/refresh` ← **Head:** `fix-555-name-field-can-be-updated-with-spaces` --- ### 📝 Commits (3) - [`7bae000`](https://github.com/documenso/documenso/commit/7bae0002cd85aae7165b0775d63953a00f97c084) fix(bug): fix only spaces_name sign - [`60c979b`](https://github.com/documenso/documenso/commit/60c979ba4f363cacbea386cf385660c715a160fc) fix(bug): added trimStart and updated ZSignFieldWithTokenMutationSchema - [`cdfcbbd`](https://github.com/documenso/documenso/commit/cdfcbbdb475187df9c33ff41eea8947e1e6f0a89) fix(bug): updated ZSignFieldWithTokenMutationSchema ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/src/app/(signing)/sign/[token]/form.tsx` (+1 -1) 📝 `apps/web/src/app/(signing)/sign/[token]/name-field.tsx` (+1 -1) 📝 `packages/trpc/server/field-router/schema.ts` (+1 -1) </details> ### 📄 Description **fixes #555** **I have fixed in two places in singup form and profile update page form. this fix improves UX as It disabled the update profile / singup button when ever the fullname was emtpy . as shown in video below !** **[updated video]** https://www.loom.com/share/f0591258760349bc9871675a480972f4?sid=7617e340-a854-4f72-b70e-2756594686b4 If any changes required let me know ! Thank You :smile: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 19:31:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 19:32:51 +03:00

[PR #1044] [CLOSED] chore: add status widget #1341

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1044

No description provided.

Rows
Columns