[PR #34] [MERGED] Add support for DNS lookup of . (root) #42

New issue

Closed

opened 2026-02-27 23:20:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:20:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spatie/dnsrecords.io/pull/34
Author: @brendt
Created: 11/2/2017
Status: ✅ Merged
Merged: 11/2/2017
Merged by: @freekmurze

Base: master ← Head: fix-dot-root-lookup

📝 Commits (2)

36ec263 Add support for DNS lookup of . (root)
cf4283e Prefer the POST command over the GET command

📊 Changes

2 files changed (+8 additions, -1 deletions)

View changed files

📝 app/Http/Controllers/HomeController.php (+4 -1)
📝 tests/Feature/DnsLookupTest.php (+4 -0)

📄 Description

The PR adds support to lookup the . (root) domain. The reason this didn't work is because browsers filter out . from the URL.

So when no search query is provided in the URL, the post body is checked whether a command is sent there. If so, that command is used as a fallback, which allows . to work. It still doesn't allow a shareable URL, but that's not possible as most browsers will filter it out before sending the GET request.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spatie/dnsrecords.io/pull/34 **Author:** [@brendt](https://github.com/brendt) **Created:** 11/2/2017 **Status:** ✅ Merged **Merged:** 11/2/2017 **Merged by:** [@freekmurze](https://github.com/freekmurze) **Base:** `master` ← **Head:** `fix-dot-root-lookup` --- ### 📝 Commits (2) - [`36ec263`](https://github.com/spatie/dnsrecords.io/commit/36ec26387e644b08ea61d0247755062a1d9d1155) Add support for DNS lookup of . (root) - [`cf4283e`](https://github.com/spatie/dnsrecords.io/commit/cf4283e43bcbdd2aaf6dc06363d24be52e3e20a1) Prefer the POST command over the GET command ### 📊 Changes **2 files changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/HomeController.php` (+4 -1) 📝 `tests/Feature/DnsLookupTest.php` (+4 -0) </details> ### 📄 Description The PR adds support to lookup the `.` (root) domain. The reason this didn't work is because browsers filter out `.` from the URL. So when no search query is provided in the URL, the post body is checked whether a command is sent there. If so, that command is used as a fallback, which allows `.` to work. It still doesn't allow a shareable URL, but that's not possible as most browsers will filter it out before sending the GET request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>