[PR #20] [MERGED] Behave like a terminal #34

New issue

Closed

opened 2026-02-27 23:20:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:20:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spatie/dnsrecords.io/pull/20
Author: @rchoffardet
Created: 10/29/2017
Status: ✅ Merged
Merged: 10/30/2017
Merged by: @freekmurze

Base: feature-terminal ← Head: feature/behave-like-a-terminal

📝 Commits (9)

9a2c0da ✨ add history feature
50fb29f Merge branch 'master' into master
121192f Merge branch 'master' into master
9b39948 📝 merge submit event
ab9e981 📝 remove else keyword by making use of early return
162dc2a 📝 end file with a newline
04e63c0 ✨ add limit to history (1000 elements max)
0373d11 ✨ behave like a terminal
b6658d2 ✨ add redirection for "old" sharable url

📊 Changes

16 files changed (+219 additions, -105 deletions)

View changed files

📝 app/Http/Controllers/HomeController.php (+6 -0)
📝 app/Services/Commands/CommandChain.php (+0 -2)
➖ app/Services/Commands/Commands/Clear.php (+0 -19)
📝 app/Services/Commands/Commands/DnsLookup.php (+8 -4)
➖ app/Services/Commands/Commands/Doom.php (+0 -19)
📝 app/Services/Commands/Commands/Ip.php (+4 -3)
📝 app/Services/Commands/Commands/Localhost.php (+4 -3)
📝 app/Services/Commands/Commands/Manual.php (+4 -3)
📝 resources/assets/css/base/headings.css (+1 -0)
➕ resources/assets/js/History.js (+49 -0)
📝 resources/assets/js/app.js (+8 -7)
➕ resources/assets/js/bootstrap.js (+13 -0)
➕ resources/assets/js/components/terminal.vue (+119 -0)
📝 resources/views/home/index.blade.php (+2 -35)
➖ resources/views/layout/_partials/flash.blade.php (+0 -10)
📝 resources/views/layout/master.blade.php (+1 -0)

📄 Description

This PR introduces a terminal-like behavior to the application as suggested in #18
Work is mostly done, but it introduces a breaking change : Shareable URL now needs to have a Hash before the command like so :
http://dnsrecords.io/#google.fr
If it matters, I have an idea to ensure backward compatibility :)

UI isn't one of my skills, so don't hesitate to give me advice/tips on how to improve it !

PS: Terminals have history so I included my previous work in #13

I also added the history -c command to clear history, I can change it to 'clear-history' or anything else.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spatie/dnsrecords.io/pull/20 **Author:** [@rchoffardet](https://github.com/rchoffardet) **Created:** 10/29/2017 **Status:** ✅ Merged **Merged:** 10/30/2017 **Merged by:** [@freekmurze](https://github.com/freekmurze) **Base:** `feature-terminal` ← **Head:** `feature/behave-like-a-terminal` --- ### 📝 Commits (9) - [`9a2c0da`](https://github.com/spatie/dnsrecords.io/commit/9a2c0da8ce48a49828f3d886c0d217000683f543) :sparkles: add history feature - [`50fb29f`](https://github.com/spatie/dnsrecords.io/commit/50fb29f5525129e71a3d98b5f7ab4c5f325395fa) Merge branch 'master' into master - [`121192f`](https://github.com/spatie/dnsrecords.io/commit/121192f31c18e1069c5954b10016fb035976ab6d) Merge branch 'master' into master - [`9b39948`](https://github.com/spatie/dnsrecords.io/commit/9b39948c3d9db7a8e7595e2036021b5694e6013f) :pencil: merge submit event - [`ab9e981`](https://github.com/spatie/dnsrecords.io/commit/ab9e981dbcf1292b9bb0a5ce011542ecc4fd7e1f) :pencil: remove else keyword by making use of early return - [`162dc2a`](https://github.com/spatie/dnsrecords.io/commit/162dc2a110482746fc3781c0146ba76515c0674f) :pencil: end file with a newline - [`04e63c0`](https://github.com/spatie/dnsrecords.io/commit/04e63c08a96bfe87c33cc05c790e5defa9a26e49) :sparkles: add limit to history (1000 elements max) - [`0373d11`](https://github.com/spatie/dnsrecords.io/commit/0373d11c25651208e3de1d8139a020b4d22af0ca) :sparkles: behave like a terminal - [`b6658d2`](https://github.com/spatie/dnsrecords.io/commit/b6658d2071c8f5132e508fcd2d3aa1d729e3d641) :sparkles: add redirection for "old" sharable url ### 📊 Changes **16 files changed** (+219 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/HomeController.php` (+6 -0) 📝 `app/Services/Commands/CommandChain.php` (+0 -2) ➖ `app/Services/Commands/Commands/Clear.php` (+0 -19) 📝 `app/Services/Commands/Commands/DnsLookup.php` (+8 -4) ➖ `app/Services/Commands/Commands/Doom.php` (+0 -19) 📝 `app/Services/Commands/Commands/Ip.php` (+4 -3) 📝 `app/Services/Commands/Commands/Localhost.php` (+4 -3) 📝 `app/Services/Commands/Commands/Manual.php` (+4 -3) 📝 `resources/assets/css/base/headings.css` (+1 -0) ➕ `resources/assets/js/History.js` (+49 -0) 📝 `resources/assets/js/app.js` (+8 -7) ➕ `resources/assets/js/bootstrap.js` (+13 -0) ➕ `resources/assets/js/components/terminal.vue` (+119 -0) 📝 `resources/views/home/index.blade.php` (+2 -35) ➖ `resources/views/layout/_partials/flash.blade.php` (+0 -10) 📝 `resources/views/layout/master.blade.php` (+1 -0) </details> ### 📄 Description This PR introduces a terminal-like behavior to the application as suggested in #18 Work is mostly done, but it introduces a breaking change : Shareable URL now needs to have a Hash before the command like so : `http://dnsrecords.io/#google.fr` If it matters, I have an idea to ensure backward compatibility :) UI isn't one of my skills, so don't hesitate to give me advice/tips on how to improve it ! PS: Terminals have history so I included my previous work in #13 I also added the `history -c` command to clear history, I can change it to 'clear-history' or anything else. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>