[PR #473] [MERGED] Revert "use uniqid instead of php array indexing for server list" #831

New issue

Closed

opened 2026-02-25 21:36:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/473
Author: @jasonmunro
Created: 5/7/2021
Status: ✅ Merged
Merged: 6/1/2021
Merged by: @jasonmunro

Base: master ← Head: revert-454-feature/server-list-by-uniqid

📝 Commits (1)

4e45bd4 Revert "use uniqid instead of php array indexing for server list"

📊 Changes

17 files changed (+53 additions, -52 deletions)

View changed files

📝 lib/servers.php (+5 -5)
📝 modules/core/setup.php (+1 -1)
📝 modules/feeds/modules.php (+4 -4)
📝 modules/feeds/setup.php (+1 -1)
📝 modules/github/modules.php (+1 -1)
📝 modules/github/setup.php (+1 -1)
📝 modules/gmail_contacts/modules.php (+1 -1)
📝 modules/imap/functions.php (+6 -5)
📝 modules/imap/handler_modules.php (+10 -10)
📝 modules/imap/output_modules.php (+2 -2)
📝 modules/imap/setup.php (+4 -4)
📝 modules/imap/site.js (+1 -1)
📝 modules/pop3/modules.php (+7 -7)
📝 modules/pop3/setup.php (+3 -3)
📝 modules/smtp/modules.php (+4 -4)
📝 modules/smtp/setup.php (+1 -1)
📝 tests/phpunit/servers.php (+1 -1)

📄 Description

Reverts jasonmunro/cypht#454

This PR was well-intentioned and I appreciate the effort but it has broken a lot of things since and I don't know what else might be effected that I have not discovered yet. Not sure if it is even possible to revert properly at this point but looking into it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/473 **Author:** [@jasonmunro](https://github.com/jasonmunro) **Created:** 5/7/2021 **Status:** ✅ Merged **Merged:** 6/1/2021 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `revert-454-feature/server-list-by-uniqid` --- ### 📝 Commits (1) - [`4e45bd4`](https://github.com/cypht-org/cypht/commit/4e45bd4a7f94a68d424f2c19b727d57ad2898601) Revert "use uniqid instead of php array indexing for server list" ### 📊 Changes **17 files changed** (+53 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `lib/servers.php` (+5 -5) 📝 `modules/core/setup.php` (+1 -1) 📝 `modules/feeds/modules.php` (+4 -4) 📝 `modules/feeds/setup.php` (+1 -1) 📝 `modules/github/modules.php` (+1 -1) 📝 `modules/github/setup.php` (+1 -1) 📝 `modules/gmail_contacts/modules.php` (+1 -1) 📝 `modules/imap/functions.php` (+6 -5) 📝 `modules/imap/handler_modules.php` (+10 -10) 📝 `modules/imap/output_modules.php` (+2 -2) 📝 `modules/imap/setup.php` (+4 -4) 📝 `modules/imap/site.js` (+1 -1) 📝 `modules/pop3/modules.php` (+7 -7) 📝 `modules/pop3/setup.php` (+3 -3) 📝 `modules/smtp/modules.php` (+4 -4) 📝 `modules/smtp/setup.php` (+1 -1) 📝 `tests/phpunit/servers.php` (+1 -1) </details> ### 📄 Description Reverts jasonmunro/cypht#454 This PR was well-intentioned and I appreciate the effort but it has broken a lot of things since and I don't know what else might be effected that I have not discovered yet. Not sure if it is even possible to revert properly at this point but looking into it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>