[PR #831] [MERGED] Fix start_page setting not being saved #1079

New issue

Closed

opened 2026-02-25 21:37:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:37:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/831
Author: @Yannick243
Created: 11/23/2023
Status: ✅ Merged
Merged: 12/1/2023
Merged by: @kroky

Base: master ← Head: fix-default-start-page

📝 Commits (1)

70d7460 Fix start_page setting not being saved

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 modules/core/output_modules.php (+1 -1)
📝 modules/core/setup.php (+1 -1)

📄 Description

Description:

The start_page setting was not being saved because special characters in certain URLs were being escaped by FILTER_SANITIZE_FULL_SPECIAL_CHARS. As a result, during the verification with the allowed_urls for that setting, they were no longer able to match.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/831 **Author:** [@Yannick243](https://github.com/Yannick243) **Created:** 11/23/2023 **Status:** ✅ Merged **Merged:** 12/1/2023 **Merged by:** [@kroky](https://github.com/kroky) **Base:** `master` ← **Head:** `fix-default-start-page` --- ### 📝 Commits (1) - [`70d7460`](https://github.com/cypht-org/cypht/commit/70d74608bef3d9421d301d1354990513e31f9449) Fix start_page setting not being saved ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/output_modules.php` (+1 -1) 📝 `modules/core/setup.php` (+1 -1) </details> ### 📄 Description ### Description: The **start_page** setting was not being saved because special characters in certain URLs were being escaped by FILTER_SANITIZE_FULL_SPECIAL_CHARS. As a result, during the verification with the allowed_urls for that setting, they were no longer able to match. Related Issue: [https://github.com/cypht-org/cypht/issues/783](https://github.com/cypht-org/cypht/issues/783) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>