[PR #455] [MERGED] Site.js in Core Module compatibility for IE11 #824

Closed
opened 2026-02-25 21:36:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/455
Author: @kmpoppe
Created: 2/25/2021
Status: Merged
Merged: 2/25/2021
Merged by: @jasonmunro

Base: masterHead: ie11-compatibility


📝 Commits (1)

  • 339d8a2 Site.js in Core Module compatibility for IE11

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modules/core/site.js (+1 -1)

📄 Description

Pullrequest

Removed =>-Notation which is part of ES6 because it's not supported by IE11.

Issues

  • None

Checklist

  • None

How2Test

  • Use Internet Explorer 11.0.9600.19596 / Updateversion 11.0.170 (KB4534251) to open the Cypht main page (after login). Before the change, line 71 of site.js would throw a syntax error on res.map(x => {return ...}). Changing this to function(x) {return ...} fixed this problem.

Todo

  • None

Source


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/455 **Author:** [@kmpoppe](https://github.com/kmpoppe) **Created:** 2/25/2021 **Status:** ✅ Merged **Merged:** 2/25/2021 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `ie11-compatibility` --- ### 📝 Commits (1) - [`339d8a2`](https://github.com/cypht-org/cypht/commit/339d8a237b38654e2fc496b27d2ed23201e41422) Site.js in Core Module compatibility for IE11 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/site.js` (+1 -1) </details> ### 📄 Description ## Pullrequest Removed `=>`-Notation which is part of ES6 because it's not supported by IE11. ### Issues - [X] None ### Checklist - [X] None ### How2Test - [X] Use Internet Explorer 11.0.9600.19596 / Updateversion 11.0.170 (KB4534251) to open the Cypht main page (after login). Before the change, line 71 of site.js would throw a syntax error on `res.map(x => {return ...})`. Changing this to `function(x) {return ...}` fixed this problem. ### Todo - [x] None ### Source - [X] https://stackoverflow.com/questions/42080078/javascript-syntax-error-on-internet-explorer --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#824
No description provided.